Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BuckleScript file type and icon. #220

Merged
merged 5 commits into from
Apr 17, 2020
Merged

Conversation

JohnPucciarelli
Copy link
Collaborator

No description provided.

@JohnPucciarelli JohnPucciarelli force-pushed the pooch/bs-config-file-type branch from 9be7e51 to 759a691 Compare April 17, 2020 13:00
import com.intellij.util.indexing.FileContentImpl;
import org.jetbrains.annotations.NotNull;

public class BsConfigJsonFile extends FileBase {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid FileBase for anything that is not a module

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is stale. Fixed now.

@giraud giraud merged commit aed2318 into master Apr 17, 2020
@JohnPucciarelli JohnPucciarelli deleted the pooch/bs-config-file-type branch April 17, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants