Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Checkpoint Selector node breaking search width #5

Open
Chubbly opened this issue Aug 25, 2023 · 3 comments
Open

[BUG] Checkpoint Selector node breaking search width #5

Chubbly opened this issue Aug 25, 2023 · 3 comments

Comments

@Chubbly
Copy link

Chubbly commented Aug 25, 2023

The Checkpoint selector node is returning a type that is a list of every checkpoint a person has. If someone has many checkpoints, this stretches out the search box (the thing that pops up when you double click on the canvas) to larger than the the viewport width, basically making search unusable. The primitive version uses a COMBO type, I'm wondering if this could be used as a return type instead.

@WinstonWoof
Copy link

same issue

@arkinson9
Copy link

same issue too

@Chubbly
Copy link
Author

Chubbly commented Aug 30, 2023

After investigating this as much as my (in)expertise will allow, the unfortunate conclusion is that there is no way to solve this with the current architecture of ComfyUI. The standard Load Checkpoint node expects a list checkpoints so the only way to fix this would be to change how the default Load Checkpoint node works.

For people wishing for a solution that still allows them to use the handy saving function from this repo, you can change the ckpt_name to an input widget and then double-click the input node to create a Combo primitive that can be passed in to the Save Image node from this repo. Or you can use the Load Checkpoint Text node from this repo https://github.com/lilly1987/ComfyUI_node_Lilly and pipe the value in, with the added benefit of using wildcards for checkpoint names. In either case, you will need to comment out class CheckpointSelector.

@giriss Unless you have spotted some other solution?

alexopus added a commit to alexopus/ComfyUI-Image-Saver that referenced this issue Jan 13, 2024
Fixes 2 issues:
 - oversized search fields (giriss#5)
 - selector breaking when model files are added/removed at runtime
alexopus added a commit to alexopus/ComfyUI-Image-Saver that referenced this issue Jan 13, 2024
Fixes 2 issues:
 - oversized search fields (giriss#5)
 - selector breaking when model files are added/removed at runtime
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants