Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GB3-1715: arrow navigation in search #69

Merged
merged 26 commits into from
Jan 27, 2025

Conversation

TIL-EBP
Copy link
Contributor

@TIL-EBP TIL-EBP commented Dec 2, 2024

This PR adds new directives that allow keyboardnavigation through search result on the map page and the start page.
One directive handles all the keyboard events, the highlighting of the selected result etc.
The other one is just there to mark search results so they can be reached via arrow keys. This are passed via ViewChildren and VieChild to the respective container,

For this, some adaptations were made to the results:
They are now fully clickable, not just the icons.
The tab navigation has been romved from many elements in order not to conflict with the arrow navigation.

Testing will be added asap

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
22.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@TIL-EBP TIL-EBP marked this pull request as ready for review December 10, 2024 16:15
@TIL-EBP TIL-EBP requested a review from wendlans December 10, 2024 16:16
Copy link
Contributor

@wendlans wendlans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Till, sorry I couldn't finish the review yet. But from what I saw yet I cannot approve this requests. There are currently some show stoppers in the frontend.
As for the code: I'll have a look into that probably on Monday. Maybe we'll find some time when you can give me an overview of the changes and your thoughts.

@TIL-EBP TIL-EBP force-pushed the feature/gb3-1715-arrow-navigation-in-search branch from 38de742 to f6f68be Compare January 16, 2025 14:14
Copy link
Contributor

@wendlans wendlans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the results but what did it cost? 😅
3fd-1977057733

Maybe let @Tugark have a second look at the base-search-container.component.ts.

Copy link
Contributor

@Tugark Tugark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look at base-search-container as @wendlans suggested.

I see that there is a lot of black magic going on, so have my approval 👍

On a more serious note: Can you have a look at the duplication warnings by Sonar and if possible, reduce/fix them? If not, head over to SonarCloud and set their status (e.g. false positive, or acknowledged-WONTFIX). If you can't log in, you maybe don't have rights, but I think we could provide them to you. That way, you would not have to bypass rules.

@TIL-EBP
Copy link
Contributor Author

TIL-EBP commented Jan 27, 2025

@Tugark I looked at the duplications and it's just the super-calls from the child components to the newly created parent compoennt base-search-container.component.ts.
So I think we can mark them as false positive. But you are right, I do not have permissions to do so (at least not with my github account).

…rom outside the search container or from within the search input field. Delegate responsibility to handle temp maps to directive
@TIL-EBP TIL-EBP force-pushed the feature/gb3-1715-arrow-navigation-in-search branch from a4cb764 to bb7cf51 Compare January 27, 2025 09:48
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@TIL-EBP TIL-EBP merged commit ce5dbd8 into develop Jan 27, 2025
7 of 8 checks passed
@TIL-EBP TIL-EBP deleted the feature/gb3-1715-arrow-navigation-in-search branch January 27, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants