GB3-1734: Add customParams for attributeFilters and TimeSlider values to print #87
+165
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendlans
requested changes
Dec 11, 2024
| @@ -177,6 +180,35 @@ export class Gb3PrintService extends Gb3ApiService { | |||
| } | |||
|
|
|||
| private createGb2WmsPrintItem(activeMapItem: ActiveMapItem, gb2WmsSettings: Gb2WmsSettings): PrintMapItem { | |||
There was a problem hiding this comment.
Please add some unit tests for this; or extend existing ones to reach the coverage goal.
TIL-EBP
force-pushed
the
feature/gb3-1734-custom-params-for-print
branch
from
ef4b602 to
37ba171
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds custom params to print for attribute filters and timesliders