Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAG selection rectangle leaves artifacts #204

Closed
sthalik opened this issue Oct 4, 2013 · 3 comments
Closed

DAG selection rectangle leaves artifacts #204

sthalik opened this issue Oct 4, 2013 · 3 comments

Comments

@sthalik
Copy link
Contributor

sthalik commented Oct 4, 2013

DAG selection rectangle leaves artifacts

Please force-refresh on selection rectangle usage.

Here are my package versions:

* dependency graph for dev-vcs/git-cola-9999
`--  dev-vcs/git-cola-9999
  `--  dev-python/jsonpickle-0.4.0-r1  (dev-python/jsonpickle) amd64  [python_targets_python2_6(-)? python_targets_python2_7(-)? python_single_target_python2_6(+)? python_single_target_python2_7(+)?]
  `--  dev-python/pyinotify-0.9.4-r1  (dev-python/pyinotify) amd64  [python_targets_python2_6(-)? python_targets_python2_7(-)? python_single_target_python2_6(+)? python_single_target_python2_7(+)?]
  `--  dev-python/PyQt4-4.10.2  (dev-python/PyQt4) amd64  [python_targets_python2_6(-)? python_targets_python2_7(-)? python_single_target_python2_6(+)? python_single_target_python2_7(+)?]
  `--  dev-vcs/git-1.8.3.2  (dev-vcs/git) ~amd64
  `--  app-text/asciidoc-8.6.5  (app-text/asciidoc) amd64
  `--  dev-python/sphinx-1.1.3-r7  (dev-python/sphinx) amd64  [python_targets_python2_6(-)? python_targets_python2_7(-)? python_single_target_python2_6(+)? python_single_target_python2_7(+)?]
  `--  app-text/xmlto-0.0.24-r1  (app-text/xmlto) amd64
  `--  sys-devel/gettext-0.18.3.1  (sys-devel/gettext) ~amd64
  `--  dev-python/nose-1.3.0  (dev-python/nose) amd64  [python_targets_python2_6(-)? python_targets_python2_7(-)? python_single_target_python2_6(+)? python_single_target_python2_7(+)?]
  `--  dev-lang/python-2.6.8-r3  (dev-lang/python) amd64
  `--  dev-lang/python-2.7.5-r2  (dev-lang/python) amd64
  `--  dev-python/python-exec-0.3.1  (dev-python/python-exec) amd64  [python_targets_python2_6(-)? python_targets_python2_7(-)? python_single_target_python2_6(+)? python_single_target_python2_7(+)?]
[ dev-vcs/git-cola-9999 stats: packages (13), max depth (1) ]
@davvid
Copy link
Member

davvid commented Jun 10, 2014

Small note: we can drop the asciidoc/xmlto dependencies these days. Please try the latest code and let me know if it mitigates the artifacts. I'll do some more testing on linux as well.

@davvid davvid closed this as completed in 059933e Jun 10, 2014
davvid added a commit to davvid/git-cola that referenced this issue Jun 10, 2014
@davvid
widgets.dag: repaint the viewport when dragging the mouse
df09e51 
This prevents selection artifacts when selecting near labels.

Related-to: git-cola#204
Signed-off-by: David Aguilar <davvid@gmail.com>
davvid added a commit to davvid/git-cola that referenced this issue Jun 10, 2014
@davvid
widgets.dag: repaint the viewport when dragging and releasing
9431eb8 
This prevents selection artifacts when selecting near labels.

Related-to: git-cola#204
Signed-off-by: David Aguilar <davvid@gmail.com>
@davvid
Copy link
Member

davvid commented Jun 10, 2014

I tested this a bit more and adding the viewport().repaint() calls definitely helped. Thanks for the heads-up.

@sthalik
Copy link
Contributor Author

sthalik commented Jun 11, 2014

Hope doesn't slow down the hot path.

Pleasure to work with you.

Note that was present on only some theme engines, e.g. QT/KDE oxygen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davvid @sthalik