Skip to content

Commit

Permalink
github: replace link with button for OAuth login
Browse files Browse the repository at this point in the history
Replace the "login using browser" link with a button on the Windows
GitHub login dialog.
  • Loading branch information
mjcheetham authored and Kyle Rader committed Aug 6, 2020
1 parent 27a0380 commit 753e93d
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions src/windows/GitHub.UI.Windows/Login/LoginCredentialsView.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,17 @@
<StackPanel>
<StackPanel Visibility="{Binding IsLoginUsingBrowserVisible, Converter={StaticResource BooleanToVisibilityConverter}}">
<StackPanel Orientation="Horizontal" HorizontalAlignment="Center">
<controls:GitHubActionLink Content="Sign in with your browser"
Command="{Binding LoginUsingBrowserCommand}"
x:Uid="loginLink"
x:Name="loginLink" />
<octicons:OcticonImage Icon="link_external" Margin="0 1 0 0"/>
<Border Style="{StaticResource LoginButtonBorder}" Margin="0 16 0 0">
<Button Command="{Binding LoginUsingBrowserCommand}"
x:Uid="loginLink"
x:Name="loginLink"
Style="{DynamicResource GitHubButton}">
<StackPanel Orientation="Horizontal">
<TextBlock>Sign in with your browser</TextBlock>
<octicons:OcticonImage Icon="link_external" Margin="5 0 0 0"/>
</StackPanel>
</Button>
</Border>
</StackPanel>
</StackPanel>

Expand Down

0 comments on commit 753e93d

Please sign in to comment.