default OAuth redirect URI to http://127.0.0.1 (#1444)

git-ecosystem · Oct 24, 2023 · e549586 · e549586
2 parents 6e06153 + ee35d7b
commit e549586
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/docs/generic-oauth.md b/docs/generic-oauth.md
@@ -40,7 +40,7 @@ following values in your Git configuration:
 
 - Client ID
 - Client Secret (optional)
-- Redirect URL
+- Redirect URL (optional, defaults to `http://127.0.0.1`)
 - Scopes (optional)
 - OAuth Endpoints
   - Authorization Endpoint

diff --git a/src/shared/Core/GenericOAuthConfig.cs b/src/shared/Core/GenericOAuthConfig.cs
@@ -104,9 +104,7 @@ public static bool TryGet(ITrace trace, ISettings settings, InputArguments input
 
             if (config.RedirectUri == null)
             {
-                trace.WriteLine($"Invalid OAuth configuration - missing/invalid redirect URI: {redirectUrl}");
-                config = null;
-                return false;
+                config.RedirectUri = new Uri("http://127.0.0.1");
             }
 
             if (settings.TryGetSetting(