Only set credential.provider for dynamic matches
#535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only set the credential.provider setting after auto-detection of the provider that used dynamic (network calls) matches. Currently we set the provider config setting after a successful auto-detection, even if we matched "simply" based on the host name (and didn't need a network call). The original idea of this "set after detect" was really to avoid having to do auto-detection _that involved a network call_, and not the cheap static matches. Change the logic in the host provider registry to only persist the provider setting if the network call was made.
mjcheetham
requested review from
derrickstolee,
ldennington,
vtbassmatt and
dscho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only set the credential.provider setting after auto-detection of the provider that used dynamic (network calls) matches.
Currently we set the provider config setting after a successful auto-detection, even if we matched "simply" based on the host name (and didn't need a network call). This means we're setting things like
credential.provider = githubforgithub.comhosts. We don't need to do this (and probably shouldn't as this may make it harder in the future to make any changes here).The original idea of this "set after detect" was really to avoid having to do auto-detection that involved a network call, and not the cheap static matches.
Change the logic in the host provider registry to only persist the provider setting if the network call was made.