msys2-runtime: restore fast path for current user primary group #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent commit removed an optimization from the Cygwin runtime that fetches the default group from the current user token: At times, this is not accurate such as when groups like the builtin Administrators group is the primary group. However, removing this optimization causes extremely poor performance when connected to some Active Directory environments. Reflecting git-for-windows/msys2-runtime#57, this update restores this optimization as the default behaviour. To still allow the user to opt into the correct behavior, a `group: db-accurate` option is provided for `nsswitch.conf`. This fixes git-for-windows/git#4459 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
/deploy |
|
/deploy msys2-runtime The workflow run was started. |
|
/add relnote bug Some Git commands (those producing paged output, for example) experienced a significant slow-down under certain circumstances, when running on a machine joined to a domain controller, which has been fixed. The workflow run was started |
github-actions bot
pushed a commit
to git-for-windows/build-extra
that referenced
this pull request
Aug 29, 2023
Some Git commands (those producing paged output, for example) experienced a [significant slow-down](git-for-windows/git#4459) under certain circumstances, when running on a machine joined to a domain controller, which [has been fixed](git-for-windows/MSYS2-packages#124). Signed-off-by: gitforwindowshelper[bot] <gitforwindowshelper-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent commit removed an optimization from the Cygwin runtime that fetches the default group from the current user token: At times, this is not accurate such as when groups like the builtin Administrators group is the primary group.
However, removing this optimization causes extremely poor performance when connected to some Active Directory environments.
Reflecting git-for-windows/msys2-runtime#57, this update restores this optimization as the default behaviour. To still allow the user to opt into the correct behavior, a
group: db-accurateoption is provided fornsswitch.conf.This fixes git-for-windows/git#4459