Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize ca-certificates with MSYS2 #49

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

dscho
Copy link
Member

@dscho dscho commented Oct 11, 2021

This brings our copy of ca-certificates up to date with MSYS2's version, and adds a GitHub workflow, in preparation for building and deploying an i686 version of this package (MSYS2 no longer builds i686 versions of their MSYS packages).

dscho added 2 commits October 8, 2021 20:59
This replaces our version with the one from 78e423b (ca-certificates:
drop expired "DST Root CA X3", 2021-10-02), in preparation for building
and uploading an i686 version of the package (MSYS2 no longer builds
i686 versions of their MSYS packages).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This workflow most notably does not try anything like `please.sh
upgrade` of the git-for-windows/build-extra repository, which tries to
figure out the latest component version and tries to upgrade to that.

Instead, this workflow builds a given package, for the specified
architecture, at the very version committed to the specified branch. The
workflow needs to be triggered manually.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Member Author

dscho commented Oct 11, 2021

Unfortunately, the only way to verify that the deployment works will be to "test in prod", after merging.

@dscho dscho merged commit 69b3183 into git-for-windows:main Oct 11, 2021
@dscho dscho deleted the sync-ca-certificates-with-msys2 branch October 11, 2021 14:56
@dscho
Copy link
Member Author

dscho commented Oct 11, 2021

@rimrul it took a while to get this where it needs to be, and I had to upload ca-certificates manually because https://github.com/git-for-windows/MSYS2-packages/actions/runs/1330488770 still failed. But I am confident that e8c5e0a fixes the remaining issue. Future builds should work.

@rimrul
Copy link
Member

rimrul commented Oct 11, 2021

Seems to be working now. 🎉

@dscho
Copy link
Member Author

dscho commented Oct 11, 2021

Seems to be working now. 🎉

Yep!

@rimrul
Copy link
Member

rimrul commented Oct 11, 2021

I'm preparing a workflow to automatically create (or update) a pr when upstream changes a package we care about. Kind of a poor-mans dependabot for MSYS2-packages.

@dscho
Copy link
Member Author

dscho commented Oct 11, 2021

I'm preparing a workflow to automatically create (or update) a pr when upstream changes a package we care about. Kind of a poor-mans dependabot for MSYS2-packages.

😁 Okay!

dscho added a commit to git-for-windows/build-extra that referenced this pull request Oct 13, 2021
The 32-bit versions of Git for Windows included outdated
versions of `ca-certificates` and `less`, [which has been
rectified](git-for-windows/MSYS2-packages#49).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants