installer: offer to launch "Git Bash" right away #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
Not really sure whether this is something people would want, so I'll leave this open for discussion for a while or so. |
According to InnoSetup's documentation, the 'isreadme' flag is obsolete (even if that has not been mentioned in InnoSetup's release notes). Let's use the recommended way to show the release notes instead. As a bonus, we can now modify the label to say "View Release Notes" (instead of "View ReleaseNotes.html"). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
Could be missleading if the user choose "cmd" integration to offer a git bash start. |
|
True. OTOH the default PATH option is going to change to Cmd, in all likelihood. So we cannot really rely on that setting stating the preference of the current user. I guess the safest would be to add the option, but leave it unchecked by default. |
The installer runs with elevated privileges; We do not want Git Bash to run with the same privileges. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Many users actually prefer cmd or PowerShell, so let's not impose. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
that referenced
this pull request
Mar 29, 2016
The installer [now offers to launch the Git Bash right away](#103). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de