Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install xz #177

Merged
merged 1 commit into from
Mar 15, 2018
Merged

Install xz #177

merged 1 commit into from
Mar 15, 2018

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Mar 15, 2018

It is widely used nowadays

Signed-off-by: Orgad Shaneh orgads@gmail.com

@dscho
Copy link
Member

dscho commented Mar 15, 2018

Thank you, this is a straight-forward and useful change.

Two questions:

  1. Does this mean that tar xf <file>.tar.xz works when this is merged? If so, let's state that in the commit message.
  2. By how much does this increase the installer size? I spent a ton of time to hammer it down again, and it would be a shame to make it heavier again to include a tool that Git itself does not need or use. If the installer size delta is small enough, let's merge this, but please do include the numbers in the commit message.

It is widely used nowadays

This makes it possible to extract tar.xz archives using `tar xf`.

The installer size for 64-bit is increased by 114K (which is ~0.3%).

Signed-off-by: Orgad Shaneh <orgads@gmail.com>
@orgads
Copy link
Contributor Author

orgads commented Mar 15, 2018

I placed it in the wrong list :)

Now did it the right way, tested and updated the commit message.

@dscho
Copy link
Member

dscho commented Mar 15, 2018

Excellent! Thank you!

@dscho dscho merged commit c71d14c into git-for-windows:master Mar 15, 2018
dscho added a commit that referenced this pull request Mar 15, 2018
The `tar` utility (included as a courtesy, not
because Git needs it) [can now unpack `.tar.xz`
archives](#177).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@orgads orgads deleted the install-xz branch March 24, 2018 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants