Show the update message in the Action Center again #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The format of `uname -s` changed in Cygwin v3.x, it seems, without anyone noticing that this script tests for a trailing `-10.0` on Windows 10 (but it is now `-10.0-<build-number>`). Let's fix that. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
1 task
|
Yeah, that explains it. There's a typo in the PR description though. It should be Windows 8 and later. |
Whoops, that's not even a typo but a misunderstanding. Fixed. |
dscho
added a commit
that referenced
this pull request
Nov 9, 2019
The "Check daily for updates" feature [uses the Action Center again](#268). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
A window that displays the download progress would be useful, too. Especially for people with slower internet connections. |
Feel free to work on this feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
git update-git-for-windowsscript tries to be smart and only show the Toast in Windows 8 and later. But the test was broken by an update to Cygwin v3.x, which changed the format of the output ofuname -s.This fixes that.