Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull option fix #292

Merged
merged 2 commits into from
Jun 5, 2020
Merged

Pull option fix #292

merged 2 commits into from
Jun 5, 2020

Conversation

rimrul
Copy link
Member

@rimrul rimrul commented Jun 5, 2020

We currently don't save the fast-forward only pull behaviour correctly.

Let's fix that.

This fixes git-for-windows/git#2668

rimrul added 2 commits June 5, 2020 15:58
6ab14d9 (installer: allow configuring the default behavior of `git pull`,
2020-05-19) introduced radio buttons to select how `git pull` behaves by default.
The `fast-forward only` option currently gets wrongly saved as `merge`, though.

Signed-off-by: Matthias Aßhauer <mha1993@live.de>
Since Version 2.27.0 sometimes saved the wrong pull behaviour to
/etc/install-options.txt, we can't quite trust the values in that file.

The values in the system config file accurately represent the pull behaviour.
Let's use those reliable records.

Signed-off-by: Matthias Aßhauer <mha1993@live.de>
@dscho dscho merged commit 2ff2ab5 into git-for-windows:master Jun 5, 2020
@dscho
Copy link
Member

dscho commented Jun 5, 2020

Thank you!

dscho added a commit that referenced this pull request Jun 6, 2020
The new \`git pull\` behavior option
[now records the \`fast-forward\` choice
correctly](#292).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@rimrul rimrul deleted the pull-option-fix branch June 26, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation: "Git Pull Behavior Option" always set to merge
2 participants