Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: add arm64 artifact option #326

Merged
merged 1 commit into from
Feb 6, 2021

Conversation

dennisameling
Copy link
Contributor

Adds ARM64 support to the installer 🚀

Currently installs ARM64 Git into C:\Program Files (x86)\Git by default.

installer/release.sh Outdated Show resolved Hide resolved
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress!

installer/release.sh Outdated Show resolved Hide resolved
installer/release.sh Outdated Show resolved Hide resolved
installer/install.iss Show resolved Hide resolved
@dscho
Copy link
Member

dscho commented Feb 4, 2021

There is one more concern that I forgot to mention earlier: if we try to include artifacts from a directory outside of the pseudo root, the given approach won't work.

It would probably make more sense to imitate the $include_pdbs approach (but you don't need to copy, you just need to set the Source: attribute to the actual (Windows) path).

I admit that the sed call in the $include_pdbs clause is not for the faint of heart ;-)

@dennisameling dennisameling force-pushed the installer-arm64 branch 2 times, most recently from 9ef9d70 to 0e969f0 Compare February 4, 2021 20:04
@dennisameling
Copy link
Contributor Author

dennisameling commented Feb 4, 2021

Alright, just applied your suggestions! I did go with copying the files though; don't know how to convert the Unix-based /arm64 path to the Windows path in this case 😊

After installation, everything looks good:

image

Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there! ;-)

installer/release.sh Show resolved Hide resolved
installer/release.sh Outdated Show resolved Hide resolved
Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
@dennisameling
Copy link
Contributor Author

Thanks! Just applied your suggestions @dscho. Tested and just had to apply a very minimal change to the sed command. Works now without copying the files first. Didn't know you can use cygpath to convert a Unix to a Windows path; learning something new every day 😊

Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@dscho dscho merged commit d2911a0 into git-for-windows:main Feb 6, 2021
@dennisameling dennisameling deleted the installer-arm64 branch February 6, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants