-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
installer: add arm64 artifact option #326
Conversation
7dd6e84
to
0a89698
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress!
There is one more concern that I forgot to mention earlier: if we try to include artifacts from a directory outside of the pseudo root, the given approach won't work. It would probably make more sense to imitate the I admit that the |
9ef9d70
to
0e969f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting there! ;-)
Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
0e969f0
to
353f4d7
Compare
Thanks! Just applied your suggestions @dscho. Tested and just had to apply a very minimal change to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Adds ARM64 support to the installer 🚀
Currently installs ARM64 Git into
C:\Program Files (x86)\Git
by default.