Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: Support Sublime Text 4 and (probably) newer #355

Merged
merged 2 commits into from
Jun 4, 2021

Conversation

rimrul
Copy link
Member

@rimrul rimrul commented Jun 4, 2021

Sublime Text has recently been released as version 4. Along with this new
version the install directory has been changed to no longer include the version
number in the directory name. Change the installer to detect newer versions of
Sublime Text and prefer them over version 3.

This fixes git-for-windows/git#3248

rimrul added 2 commits June 4, 2021 18:16
Sublime Text has recently been released as version 4. Along with this new
version the install directory has been changed to no longer include the version
number in the directory name. Change the installer to detect newer versions of
Sublime Text and prefer them over version 3.

This fixes git-for-windows/git#3248

Signed-off-by: Matthias Aßhauer <mha1993@live.de>
Sublime Text 4 [now gets detected by the installer](git-for-windows#355).

Signed-off-by: Matthias Aßhauer <mha1993@live.de>
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dscho dscho merged commit 8d01cee into git-for-windows:main Jun 4, 2021
@rimrul rimrul deleted the sublime4 branch June 4, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installer cannot proceed if Sublime Text is selected, but ST4 is installed, not ST3.
2 participants