Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide explicit GUID for Windows Terminal profile #356

Merged
merged 1 commit into from
Jun 10, 2021
Merged

provide explicit GUID for Windows Terminal profile #356

merged 1 commit into from
Jun 10, 2021

Conversation

jeremyd2019
Copy link
Contributor

This allows user-customizations of the profile to continue to refer to the profile even if its name or directory should change.

Based on discussion from microsoft/terminal#10374 and #339 (comment)

This allows user-customizations of the profile to continue to refer to the profile even if its name or directory should change.

Signed-off-by: Jeremy Drake <github@jdrake.com>
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@dscho dscho merged commit d5dd8e7 into git-for-windows:main Jun 10, 2021
@dscho
Copy link
Member

dscho commented Jun 10, 2021

@jeremyd2019 out of sheer curiosity: what was the process you used to generate that GUID?

dscho added a commit that referenced this pull request Jun 10, 2021
The Windows Terminal profile is now identified [by a
GUID](#356),
for more robust customization.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@rimrul
Copy link
Member

rimrul commented Jun 10, 2021

This python3 code:

From microsoft/terminal#10374 (comment)

import uuid

# CALCULATE NAMESPACE BASED ON FRAGMENT FOLDER NAME
u = uuid.uuid5(uuid.UUID("{f65ddb7e-706b-4499-8a50-40313caf510a}"), "Git".encode("UTF-16LE").decode("ASCII"))
 
# CALCULATE FINAL BASED ON NAMESPACE
uuid.uuid5(u, "Git Bash".encode("UTF-16LE").decode("ASCII"))

 # For Git/Git Bash: UUID('2ece5bfe-50ed-5f3a-ab87-5cd4baafed2b')

@dscho
Copy link
Member

dscho commented Jun 10, 2021

This python3 code: [...]

Awesome. Thank you for educating me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants