Move Git Credential Manager out of Git's exec path #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Git Credential Manager is really a stand-alone product and not part of core Git. But putting its executable into core Git's exec path gave that misleading impression. Let's just move it out of the exec path into the regular `bin/` directory, just like we did with Git LFS in a57279d (Move git-lfs binary back out of git-core, 2017-04-06). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
mjcheetham
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
This looks good to me! It would be good to move ourselves out of the soup of core binaries somewhat.
GCM doesn't have any expectations on its location when bundled (libexec/ or otherwise) so there should be no direct impact on us.
There may/will be impact on those consumers of MinGit that call GCM directly in their applications (such as Visual Studio), and they'll need to update their relative file paths to match this change.
@ldennington for visibility
ldennington
approved these changes
Apr 28, 2022
estalldecker
added a commit
to estalldecker/WSL
that referenced
this pull request
Jun 15, 2022
The path to git-credential-manager-core.exe has changed according to this [PR](git-for-windows/build-extra#406) and the comments in the [v2.36.1 release notes](https://github.com/git-for-windows/git/releases/tag/v2.36.1.windows.1)
hkuno9000
added a commit
to hkuno9000/cygbin
that referenced
this pull request
Apr 27, 2023
hkuno9000
added a commit
to hkuno9000/cygbin
that referenced
this pull request
Apr 27, 2023
hkuno9000
added a commit
to hkuno9000/cygbin
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At long last, we do the same with Git Credential Manager as did with Git LFS in a57279d: we move its executables into the regular
/mingw64/bin/directory (or/mingw32/bin/in i686 setups).This provides for a cleaner separation between the non-built-in Git commands that are part of core Git (which are supposed to live in Git's exec path) and third-party commands such as Git LFS, Git Credential Manager, or even Git for Windows'
git update-git-for-windowsandgit credential-helper-selector.It will also open the door for addressing git-for-windows/git#3668 by teaching Git an option to override the standard
PATHsearch behavior for third-party Git commands only (current idea is to look throughPATHand not use the first, but the one with the most recentctime).