git-extra: disable CBC ciphers in ssh_config again #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had to re-enable them in b46fba6 (git-extra: re-enable some SSHv1 protocols, 2017-10-12) after an OpenSSH upgrade disabled them. The reason why we had to re-enable those ciphers is gone now, though: Azure Repos understand newer (safer) ciphers. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
The build is running. |
And it succeeded! |
dscho
added a commit
that referenced
this pull request
Jun 2, 2022
SSH's CBC ciphers, which were re-enabled in 2017 to better support Azure Repos [have again been disabled by default](#421) because Azure Repos does not require them any longer. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to re-enable them in b46fba6 (git-extra: re-enable some SSHv1 protocols, 2017-10-12) after an OpenSSH upgrade disabled them.
The reason why we had to re-enable those ciphers is gone now, though: Azure Repos understand newer (safer) ciphers.