Issue 4172: handle processes names ending with .exe #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes git-for-windows/git#4172 Signed-off-by: Jean-Michel Mercier <jeanmichel.mercier@newsbridge.io> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
Issue-4172-handle-process-name-terminated-with-.exe
branch
from
e54bf0c to
c6b8a55
Compare
|
@jeanmichel-nwsb I edited the commit message and the patch a bit, could you please test to confirm that it still fixes the reported problem? |
|
Hi @dscho |
|
Hi @dscho
From the code I was under the impression it would try to terminate the processes before displaying this page but I'm probably wrong with understanding the logic of InnoSetup pages So for me all good 👍
|
1 task
Yes, it is intended. It says "will be terminated" to notify the user that this is going to happen instead of silently stopping the processes. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 19, 2022
The installer is expected to stop GPG agents automatically, but there prevented that from working, which [has been fixed](#453). Signed-off-by: gitforwindowshelper[bot] <gitforwindowshelper-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jean-Michel Mercier [jeanmichel.mercier@newsbridge.io](mailto:jeanmichel.mercier@newsbridge.io
This PR fix the detection of running executable as on current version of Windows, the Process.Name may ends with
.exewhich make the comprison fails, and the processes are not marked to be terminated.