Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: drop support for Windows 7 and 8.0 #479

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

dennisameling
Copy link
Contributor

@dennisameling dennisameling commented Feb 8, 2023

As announced in July 2022, Git for Windows is dropping support for these older Windows versions, following MSYS2's lead. Let's make sure that the installer actively blocks the installation process on these versions. The minimal Windows version is now 8.1 (6.3).

Looking ahead: if the minimum version reaches 10.0, GfW could choose to switch to CLANG64 instead of the current MINGW64, which is using the more modern ucrt C library. Our recent work on CLANGARM64 support paves the way for this potential future switch ✨

As announced in July 2022, Git for Windows is dropping support for these
older Windows versions, following MSYS2's lead. Let's make sure that the
installer actively blocks installation on these versions.

Ref: https://github.com/git-for-windows/build-extra/blob/main/ReleaseNotes.md#changes-since-git-for-windows-v2371-july-12th-2022
Ref: https://github.com/msys2/msys2.github.io/blob/source/web/news.md#2023-01-15---dropping-support-for-windows-7-and-80
Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
@dscho
Copy link
Member

dscho commented Feb 9, 2023

As announced in July 2022, Git for Windows is dropping support for these older Windows versions, following MSYS2's lead

While that is true, I forgot to repeat that warning in quite a few releases since then. That's why I added the warning again, for the next release yesterday.

So I think that this PR might need a while before it can be merged.

But you got me thinking: maybe we should warn users who install the next Git for Windows version if their Windows version will soon no longer be supported? Something similar to the warning about a downgrade, except instead of checking for the Git for Windows version we would check for the Windows version, similar to what we do when detecting support for symbolic links)?

And once the time actually comes to drop Windows 7/8.0 support, the big change will be to upgrade to MSYS2 runtime v3.5.* (which is not even available yet because Cygwin did not release any v3.5.* version yet). But maybe we should follow Cygwin's lead in prominently declaring one version "the last one to support Windows 7"? Like they do on their home page:

image

Looking ahead: if the minimum version reaches 10.0, GfW could choose to switch to CLANG64 instead of the current MINGW64, which is using the more modern ucrt C library. Our recent work on CLANGARM64 support paves the way for this potential future switch ✨

Given how finicky even something like the malloc() performance of different CRT versions is (in my mimalloc work, I was able to replicate some poor performance numbers even with recent CRT versions), I am not quite as enthusiastic about that switch. It sounds like quite a risk to me, to be honest, especially in conjunction with switching from GCC to clang (which implies using a low-level virtual machine whose performance characteristics I never thoroughly investigated).

@dscho
Copy link
Member

dscho commented Feb 9, 2023

Given that MSYS2 runtime v3.5.0 will drop support for Windows 7/8, but v3.4.0 already dropped i686 support, I realized that the latter is much more pressing. I opened git-for-windows/git#4279 for that.

@dennisameling
Copy link
Contributor Author

Ok, let's just mark this PR as draft then. Feel free to close this completely if you feel this is premature 👍🏼

@dennisameling dennisameling marked this pull request as draft February 9, 2023 20:27
@dscho
Copy link
Member

dscho commented Feb 10, 2023

Ok, let's just mark this PR as draft then. Feel free to close this completely if you feel this is premature 👍🏼

Oh, let's keep it open. I would not even have minded keeping it in non-draft mode ;-)

Toohott23

This comment was marked as spam.

@rimrul
Copy link
Member

rimrul commented Oct 6, 2023

Given that MSYS2 runtime v3.5.0 will drop support for Windows 7/8

git-ecosystem/git-credential-manager#1418

Git Credential Manager is now also working on dropping support for Windows 7/8.

EDIT: Unlike this PR, that also means no more Windows 8.1 support

@rimrul rimrul marked this pull request as ready for review November 26, 2024 11:06
@rimrul rimrul merged commit 41e8b83 into main Nov 26, 2024
@rimrul rimrul deleted the drop-windows-7-windows-8-0-support branch November 26, 2024 11:39
@rimrul
Copy link
Member

rimrul commented Nov 26, 2024

/add relnote bug The installer now correctly blocks the installation on Windows 7 and Windows 8 as these versions of Windows are no longer supported since Git for Windows v2.47.0

The workflow run was started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants