Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Git Bash support for systems with mandatory ASLR enabled #512

Closed
wants to merge 2 commits into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Jul 22, 2023

Implemented Git Bash support for systems with mandatory ASLR enabled by modifying the post installation Batch script to add mandatory ASLR security exceptions for the executables in the "usr/bin" directory.

Fixes:

Implemented Git Bash support for systems with mandatory ASLR enabled by modifying the post installation Batch script to add mandatory ASLR security exceptions for the executables in the "usr/bin" directory.

Signed-off-by: Andrew Riseborough <AndyBorah38@gmail.com>
@rimrul
Copy link
Member

rimrul commented Jul 22, 2023

Do we still need ASLR exceptions with 64 Bit Git for Windows 2.41.0 and newer? The Cygwin 3.4.* based Msys2 runtime should work with full ASLR.

git-for-windows/git#1412 (comment)

Please, and I must reiterate, do not automatically deactivate, disable, or otherwise circumvent security options users or administrators have set up.

This user does have a point, we shouldn't just add security exceptions without asking when run as an administrator.

@ghost
Copy link
Author

ghost commented Jul 22, 2023

Do we still need ASLR exceptions with 64 Bit Git for Windows 2.41.0 and newer? The Cygwin 3.4.* based Msys2 runtime should work with full ASLR.

git-for-windows/git#1412 (comment)

Please, and I must reiterate, do not automatically deactivate, disable, or otherwise circumvent security options users or administrators have set up.

This user does have a point, we shouldn't just add security exceptions without asking when run as an administrator.

Yes we still need ASLR exceptions with 64 Bit Git for Windows 2.41.0 and newer or at least I need them on my Windows 10 Pro x64 machine and I didn't consider that but I guess it would be proper to always prompt the user unless they supply the silent flags.

I'll get on editing it as soon as possible.

Fixed the scripts character encoding which was causing it to be improperly displayed unless cloned.

Signed-off-by: Andrew Riseborough <AndyBorah38@gmail.com>
Repository owner closed this by deleting the head repository Jul 22, 2023
@dscho
Copy link
Member

dscho commented Jul 23, 2023

The Cygwin 3.4.* based Msys2 runtime should work with full ASLR.

See msys2/msys2-runtime@a556be7, though.

@rimrul
Copy link
Member

rimrul commented Jul 24, 2023

See msys2/msys2-runtime@a556be7, though.

I forgot about that. That would explain it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants