An idea to prevent CMD from picking up any git.exe in the current directory

[gdh1995]

The release note in https://github.com/git-for-windows/git/releases/tag/v2.19.2.windows.1 says:

It is impossible to turn off CMD's behavior where it picks up any git.exe in the current directory, so let's discourage the use of Git CMD.

I agree with it, but I think there may be a way to make CMD not use the git.exe in the current directory - according to $PATHEXT, git.com takes precedence over git.exe, so if only there's /usr/bin/git.com, then a command like git status will use it directly.

Just a naive idea~

[dscho]

Have you tested your idea?

[gdh1995]

Have you tested your idea?

Sorry to bother you. My idea of using git.com can not pass any simple test.

Maybe DOSKEY is another solution. Here's my test (after cp /usr/bin/ls.exe /r/working/git.exe):

R:\working$ DOSKEY git=D:\Git\mingw64\bin\git.exe $*

R:\working$ git --version
git version 2.19.2.windows.1

R:\working$ .\git --version
ls (GNU coreutils) 8.30
...

This new idea is learned from https://stackoverflow.com/questions/20530996/aliases-in-windows-command-prompt.

[dscho]

Sorry to bother you.

Not at all!

My idea of using git.com can not pass any simple test.

That's too sad...

Maybe DOSKEY is another solution.

That's a really good idea! I just performed a few tests with this, and it seems to work quite well!

[dscho]

Fixed via git-for-windows/MINGW-packages@8217238

[gdh1995]

Thanks.

BTW, I just wonder whether the commit can still work even when @@EXEPATH@@ contains any space characters.

[gdh1995]

Um... A sadly news is, I just test a new command of echo 1 | git log, and find that CMD fallback to search PATH for git.exe. CMD is indeed too annoying.

[dscho]

I just wonder whether the commit can still work even when @@EXEPATH@@ contains any space characters.

It should, as the path is inside quotes.

A sadly news is, I just test a new command of echo 1 | git log, and find that CMD fallback to search PATH for git.exe.

That is indeed sad! Oh well. At least it works for the common case, as it is quite unusual to pipe something into git, especially in CMD.

So I guess we keep Git CMD deprecated, but ship with your fix from now on?

[mfriedrich74]

You could have a look here if, you get the SafeDllSearchMode somehow enabled for the process and child processes. https://docs.microsoft.com/en-us/windows/desktop/dlls/dynamic-link-library-search-order

…

On Fri, Nov 23, 2018 at 5:10 AM Johannes Schindelin < ***@***.***> wrote: I just wonder whether the commit can still work even when @@EXEPATH@@ contains any space characters. It should, as the path is inside quotes. A sadly news is, I just test a new command of echo 1 | git log, and find that CMD fallback to search PATH for git.exe. That is indeed sad! Oh well. At least it works for the common case, as it is quite unusual to pipe something into git, especially in CMD. So I guess we keep Git CMD deprecated, but ship with your fix from now on? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1945 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHJ-yP2a7jYtV70Qo9Ovqc0mBORS4dIIks5ux8l9gaJpZM4Yuq5c> .

[dscho]

@mfriedrich74 if you somehow get the SafeDllSearchMode to apply to CMD's .exe search, that will be quite the trick.