Unable to read exclude file on network drive

[xaelophorus]

• I was not able to find an open or closed issue matching what I'm seeing

Setup

• Which version of Git for Windows are you using? Is it 32-bit or 64-bit?

2.20.1, 64-bit

$ git --version --build-options

git version 2.20.1.windows.1
cpu: x86_64
built from commit: 7c9fbc07db0e2939b36095df45864b8cda19b64f
sizeof-long: 4
sizeof-size_t: 8

• Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?

Windows 7, 64-bit

$ cmd.exe /c ver

Microsoft Windows [Version 6.1.7601]

• What options did you set as part of the installation? Or did you choose the
  defaults?

# One of the following:
> type "C:\Program Files\Git\etc\install-options.txt"
> type "C:\Program Files (x86)\Git\etc\install-options.txt"
> type "%USERPROFILE%\AppData\Local\Programs\Git\etc\install-options.txt"
$ cat /etc/install-options.txt

Editor Option: Notepad++
Custom Editor Path:
Path Option: Cmd
SSH Option: OpenSSH
CURL Option: WinSSL
CRLF Option: CRLFAlways
Bash Terminal Option: ConHost
Performance Tweaks FSCache: Enabled
Use Credential Manager: Enabled
Enable Symlinks: Disabled

• Any other interesting things about your environment that might be related
  to the issue you're seeing?

Most of my Git work is done on a mapped network drive.

Details

• Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

Bash (also happens on CMD)

• What commands did you run to trigger this issue? If you can provide a
  Minimal, Complete, and Verifiable example
  this will help us understand the issue.

# Drive "Z" is a mapped network drive
cd "/z/[username]/My Documents/Repository"
git init testrepo
cd testrepo
git status

• What did you expect to occur after running these commands?

Expected output from git status to be the default output for an empty Git repository:

$ git status
On branch master

No commits yet

nothing to commit (create/copy files and use "git add" to track)

• What actually happened instead?

Received a fatal error:

$ git status
fatal: cannot use .git/info/exclude as an exclude file

• If the problem was occurring with a specific repository, can you provide the
  URL to that repository to help us with testing?

Not a public repository.

Additional Info

I downgraded to 2.19.1 and did not get the error. I then tested with 2.20.0 and received the same error as above. The error is not present when using a local drive (not network).

[PhilipOakley]

do any other (git?) commands work?

Is the file actually there, or not? and what about the .git and .git/info directory?

Do you know what sort of a network drive it is (type and style of file system / server / network connection etc)

[alegrigoriev]

There's been a few changes in add_excludes() function, to use fscache for exclude files. I guess one of them caused the regression.

[xaelophorus]

do any other (git?) commands work

git branch does seem to work normally. If there are any specific commands you would like me to test, I'd be glad to. When running git status on a non-empty repo on the network drive, the output is as follows:

$ git status
baninst1/Functions/f_fgc_wtailor_redirect.sql: Function not implemented
baninst1/Packages/pkg_bdy_ybwsksurv.sql: Function not implemented
baninst1/Packages/pkg_hdr_ybwsksurv.sql: Function not implemented
fatal: cannot use .git/info/exclude as an exclude file

The "Function not implemented" message seems to appear for every (non-Git) file in the repo.

Is the file actually there, or not? and what about the .git and .git/info directory?

Yes, the file is there. From empty repo testrepo:

$ cat .git/info/exclude
# git ls-files --others --exclude-from=.git/info/exclude
# Lines that start with '#' are comments.
# For a project mostly in C, the following would be a good set of
# exclude patterns (uncomment them if you want to use them):
# *.[oa]
# *~

Do you know what sort of a network drive it is (type and style of file system / server / network connection etc)

It's an NTFS file system shared via SMB protocol, I believe. I'll have to verify that with our network guys.

[dscho]

Do you know what sort of a network drive it is (type and style of file system / server / network connection etc)

It's an NTFS file system shared via SMB protocol, I believe. I'll have to verify that with our network guys.

Please do. Neither I nor @benpeart were able to reproduce the issue you reported, I tried with \\localhost\c$ and with a Samba directory running in a Hyper-V Ubuntu VM. I simply do not get this error. Maybe Windows 7 is the culprit?

[dscho]

Closed via #2044

[dscho]

A new snapshot is available that should fix this issue. Could I ask y'all to please test?

[xaelophorus]

Happy to say that the latest snapshot (commit 9f16cdd) no longer has this issue. Thanks!