-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portable GfW no longer runs from network drive #2036
Comments
This sounds like a symptom of another 'corner case' problem that's recently been reported for some files on network devices (#1989), Maybe. |
I am not quite sure that it is the same issue. It sounds more related to recent changes in |
Since 521a655 (git: fix 'cmd/git.exe' cannot launcher symlink, 2018-12-08), we always try to resolve the Git wrapper's executable path if it is a symbolic link. We do that by calling GetFinalPathNByHandle(), but that introduced a regression where we would not handle UNC paths correctly. This fixes git-for-windows/git#2036 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Portable Git [can be launched via network paths again](git-for-windows/git#2036). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
A new snapshot is available that should fix this issue. Could I ask y'all to please test? |
I just tried this snapshot: PortableGit-prerelease-2.20.1.windows.1.27.g9f16cdd421-64-bit.7z.exe |
@cfbrobak thanks for testing. However, I just unpacked that portable Git into PS C:\Users\me> & '\\localhost\d$\test-git\portable-2.20.1-cmd-fix\cmd\git.exe' version
git version 2.20.1.windows.1.27.g9f16cdd421 So it works here. If it fails on your side, could you try the same as I did? And if that works, provide a bit more detail what else you did? Like, details about your particular setup, e.g. is this a Samba drive or something more obscure? |
The problem is only seen if Portable GfW is unpacked on a network drive, not when unpacked on a local drive as in your own test.
As you can see version 2.18.0 works, as have all(?) previous versions. |
Sorry, I just tried on a network drive that is on a different continent, and it still worked: PS C:\Users\me> \\us-east2\users\me\portable-20190129\cmd\git version
git version 2.20.1.windows.1.27.g9f16cdd421 The same happens when I map a Samba directory from an Ubuntu VM: PS C:\Users\me> Z:\portable-20190129\cmd\git version
git version 2.20.1.windows.1.27.g9f16cdd421 This all makes me think that it is actually very important to know more about your setup, or maybe there is a chance that you can run some custom-built code in a debugger? You would have to install Git for Windows' SDK for that. Alternatively, I would need to have interactive access to the setup (we could Live Share so you can verify that I do not do anything untoward with your system). If none of that is an option, there is unfortunately nothing I can do to help. |
Unfortunately, I am unable to do any of the things that you suggest, the reason being that this is a computer at my job. |
Sorry, those are too many obstacles for me to help. |
Setup
defaults?
to the issue you're seeing?
Version 2.18.0 is also installed in the same way (directory "H:\DevTools\pgm\Git-2.18.0") and runs without problems.
Details
PowerShell or cmd.exe
Minimal, Complete, and Verifiable example
this will help us understand the issue.
The text was updated successfully, but these errors were encountered: