gitk path filter fails with backslashes #2293

gix · 2019-08-18T22:15:53Z

I was not able to find an open or closed issue matching what I'm seeing

Setup

Which version of Git for Windows are you using? Is it 32-bit or 64-bit?

$ git --version --build-options

git version 2.23.0.windows.1
cpu: x86_64
built from commit: 4db2e5cc9e1522131a039cbad3970f147a39f0ce
sizeof-long: 4
sizeof-size_t: 8

Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?

$ cmd.exe /c ver

Microsoft Windows [Version 10.0.18362.239]

Details

Commit b136617 broke gitk's file path filtering for paths containing backslashes, e.g. gitk foo\bar.txt fails to list any commits with bar.txt. The backslashes have to be escaped before piping to git.

The text was updated successfully, but these errors were encountered:

PhilipOakley · 2019-08-19T11:20:39Z

@gix Thanks for the reference to the commit. Were you able to see where the quoting should go?

A PR would be welcome !
(annoying that no one spotted the issue earlier but such are release candidates...)

gix · 2019-08-19T18:55:11Z

I've added a pull request with the simple fix I'm using locally. I don't think anything else needs escaping or special handling here (Paths with whitespaces are broken which is another issue though).

Fixes git-for-windows#2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

gix · 2019-09-23T08:26:09Z

Ping. Just hit this again on a new machine. As stated in the comments for pull request #2297 the extra escaping is not required for git, but because Tcl's IO stuff requires it, and would be a problem on Linux, too.

dscho · 2019-09-24T15:35:07Z

Thanks for the ping!

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

We just started piping the file paths via `stdin` instead of passing them via the command-line, to avoid running into command-line limitations. However, since we now pipe the file paths, we need to take care of special characters. This fixes git-for-windows/git#2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Fixes git-for-windows#2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

We just started piping the file paths via `stdin` instead of passing them via the command-line, to avoid running into command-line limitations. However, since we now pipe the file paths, we need to take care of special characters. This fixes git-for-windows#2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Fixes git-for-windows#2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

gix mentioned this issue Aug 19, 2019

gitk: Escape file paths before piping to git log #2297

Merged

gix added a commit to gix/git that referenced this issue Aug 22, 2019

gitk: Escape file paths before piping to git log

f0fe528

Fixes git-for-windows#2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

weekly-digest bot mentioned this issue Aug 25, 2019

Weekly Digest (18 August, 2019 - 25 August, 2019) #2305

Closed

dscho closed this as completed in #2297 Sep 24, 2019

dscho added this to the v2.23.0(2) milestone Sep 24, 2019

git-for-windows-ci pushed a commit that referenced this issue Sep 24, 2019

gitk: Escape file paths before piping to git log

144c409

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue Sep 24, 2019

gitk: Escape file paths before piping to git log

4e124bd

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue Sep 24, 2019

gitk: Escape file paths before piping to git log

1663be8

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

dscho pushed a commit that referenced this issue Sep 24, 2019

gitk: Escape file paths before piping to git log

023b69d

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue Sep 28, 2019

gitk: Escape file paths before piping to git log

f14189d

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue Sep 28, 2019

gitk: Escape file paths before piping to git log

0d53f6c

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue Sep 29, 2019

gitk: Escape file paths before piping to git log

5af84ae

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue Sep 30, 2019

gitk: Escape file paths before piping to git log

d0374c3

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue Sep 30, 2019

gitk: Escape file paths before piping to git log

f01ec3b

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue Sep 30, 2019

gitk: Escape file paths before piping to git log

1aa1ade

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue Sep 30, 2019

gitk: Escape file paths before piping to git log

70a80b1

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

dscho pushed a commit that referenced this issue Oct 2, 2019

gitk: Escape file paths before piping to git log

c092c2c

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

dscho pushed a commit that referenced this issue Oct 2, 2019

gitk: Escape file paths before piping to git log

4444473

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue Oct 3, 2019

gitk: Escape file paths before piping to git log

a023b9c

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue Apr 28, 2023

gitk: Escape file paths before piping to git log

9e85987

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue Apr 28, 2023

gitk: Escape file paths before piping to git log

092b83d

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue May 1, 2023

gitk: Escape file paths before piping to git log

392ee6b

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue May 1, 2023

gitk: Escape file paths before piping to git log

8347a91

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue May 1, 2023

gitk: Escape file paths before piping to git log

9b99e1e

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

dscho pushed a commit that referenced this issue May 2, 2023

gitk: Escape file paths before piping to git log

f54f915

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue May 2, 2023

gitk: Escape file paths before piping to git log

cd5d066

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue May 2, 2023

gitk: Escape file paths before piping to git log

085c958

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue May 3, 2023

gitk: Escape file paths before piping to git log

1c538b1

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue May 3, 2023

gitk: Escape file paths before piping to git log

a622c6d

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue May 3, 2023

gitk: Escape file paths before piping to git log

b051c7c

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue May 3, 2023

gitk: Escape file paths before piping to git log

6f992f4

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue May 5, 2023

gitk: Escape file paths before piping to git log

64f5b35

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue May 5, 2023

gitk: Escape file paths before piping to git log

3fdbe33

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue May 5, 2023

gitk: Escape file paths before piping to git log

ce71216

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue May 6, 2023

gitk: Escape file paths before piping to git log

7c03b57

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

dscho pushed a commit to dscho/git that referenced this issue May 8, 2023

gitk: Escape file paths before piping to git log

9fce603

Fixes git-for-windows#2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue May 8, 2023

gitk: Escape file paths before piping to git log

a078ece

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

dscho pushed a commit to dscho/git that referenced this issue May 11, 2023

gitk: Escape file paths before piping to git log

7c6a872

Fixes git-for-windows#2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue May 13, 2023

gitk: Escape file paths before piping to git log

11d3bd9

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

dscho pushed a commit that referenced this issue May 13, 2023

gitk: Escape file paths before piping to git log

5d38ab1

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue May 13, 2023

gitk: Escape file paths before piping to git log

0a6bbc2

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

dscho pushed a commit that referenced this issue May 15, 2023

gitk: Escape file paths before piping to git log

612fad3

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue May 15, 2023

gitk: Escape file paths before piping to git log

39fe3c9

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

git-for-windows-ci pushed a commit that referenced this issue May 15, 2023

gitk: Escape file paths before piping to git log

495855e

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

dscho pushed a commit that referenced this issue May 20, 2023

gitk: Escape file paths before piping to git log

43d46ca

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

dscho pushed a commit that referenced this issue May 25, 2023

gitk: Escape file paths before piping to git log

bc40a21

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

dscho pushed a commit that referenced this issue Jun 2, 2023

gitk: Escape file paths before piping to git log

0c90c19

Fixes #2293 Signed-off-by: Nico Rieck <nico.rieck@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gitk path filter fails with backslashes #2293

gitk path filter fails with backslashes #2293

gix commented Aug 18, 2019

PhilipOakley commented Aug 19, 2019

gix commented Aug 19, 2019

gix commented Sep 23, 2019

dscho commented Sep 24, 2019

gitk path filter fails with backslashes #2293

gitk path filter fails with backslashes #2293

Comments

gix commented Aug 18, 2019

Setup

Details

PhilipOakley commented Aug 19, 2019

gix commented Aug 19, 2019

gix commented Sep 23, 2019

dscho commented Sep 24, 2019