Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git for Windows 2.26.1 and up crash on "git log" custom date format (--pretty='format:%cd') #3624

Closed
3c0 opened this issue Jan 11, 2022 · 4 comments · Fixed by #3626
Closed
Milestone

Comments

@3c0
Copy link

3c0 commented Jan 11, 2022

Setup

$ git --version --build-options

git version 2.34.1.windows.1
cpu: i686
built from commit: 2ca94ab318509b3c271e82889938816bad76dfea
sizeof-long: 4
sizeof-size_t: 4
shell-path: /bin/sh
feature: fsmonitor--daemon
  • Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?
$ cmd.exe /c ver

Microsoft Windows [version 10.0.19044.1415]
  • What options did you set as part of the installation? Or did you choose the
    defaults?
# One of the following:
> type "C:\Program Files\Git\etc\install-options.txt"

Editor Option: VIM
Custom Editor Path:
Default Branch Option:
Path Option: Cmd
SSH Option: OpenSSH
Tortoise Option: false
CURL Option: OpenSSL
CRLF Option: CRLFAlways
Bash Terminal Option: MinTTY
Git Pull Behavior Option: Rebase
Use Credential Manager: Disabled
Performance Tweaks FSCache: Enabled
Enable Symlinks: Enabled
Enable Pseudo Console Support: Disabled
Enable FSMonitor: Disabled

Details

  • Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

GNU bash, version 4.4.23(1)-release (i686-pc-msys)

git log --date='format:%Y-%m-%d %H:%M' --pretty='format:%cd'
  • What did you expect to occur after running these commands?

Listing of commit dates.

  • What actually happened instead?

Segmentation fault

  • Origin of bug :

Git for Windows 2.26.1
Bug Fixes : Git now accepts more date formats such as %g and %V.

@dscho
Copy link
Member

dscho commented Jan 11, 2022

git log --date='format:%Y-%m-%d %H:%M' --pretty='format:%cd'

Note that this works in x86_64 builds, but crashes in i686 builds.

@dscho
Copy link
Member

dscho commented Jan 11, 2022

I suspect that this might be fixed by git#1181, and am testing that theory now.

@dscho
Copy link
Member

dscho commented Jan 11, 2022

I suspect that this might be fixed by git#1181, and am testing that theory now.

Turns out that is exactly the case. Git for Windows PR is up: #3626

@dscho dscho added this to the v2.35.0 milestone Jan 11, 2022
@3c0
Copy link
Author

3c0 commented Jan 11, 2022

Turns out that is exactly the case. Git for Windows PR is up: #3626

Wow! Perfect timing and thank you @dscho for the prompt inquiry and resolution.

@3c0 3c0 closed this as completed Jan 11, 2022
dscho added a commit to git-for-windows/build-extra that referenced this issue Jan 12, 2022
A [bug](git-for-windows/git#3624) which
caused crashes when running `git log` with custom date formats in
32-bit builds was fixed.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants