Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New gcm-core version] GCM 2.0.886 #4166

Closed
github-actions bot opened this issue Dec 15, 2022 · 3 comments · Fixed by git-for-windows/build-extra#451
Closed

[New gcm-core version] GCM 2.0.886 #4166

github-actions bot opened this issue Dec 15, 2022 · 3 comments · Fixed by git-for-windows/build-extra#451

Comments

@github-actions
Copy link

install from source: publish before attempting install (#987)

The changes from 3978b0e introduced a bug in the install from source
workflow - we were attempting to copy binaries before publishing them!
Fixing with this change.

Validated with [this passing
workflow](https://github.com/ldennington/git-credential-manager/actions/runs/3652773502)
in my fork.

https://github.com/GitCredentialManager/git-credential-manager/releases/tag/v2.0.886

@dscho
Copy link
Member

dscho commented Dec 15, 2022

/open pr

The workflow run was started

@rimrul
Copy link
Member

rimrul commented Dec 15, 2022

This is also the version that should fix #4165

@dscho
Copy link
Member

dscho commented Dec 15, 2022

/add release note

The workflow run was started

dscho added a commit that referenced this issue Dec 16, 2022
The `monitor-components` workflow's purpose is to notify the Git for
Windows maintainers when new package versions are published and may need
to be integrated into Git for Windows.

This PR brings two improvements to this workflow:

- We now explicitly disable the workflow everywhere but the Git for
Windows fork of Git, instead of relying on scheduled workflows being
disabled in forks (of the fork) by default.
- The label and the URL of the Git Credential Manager part was fixed. I
noticed that the label was wrong when
git-for-windows/build-extra#451 was opened but
failed to mention that it would close the issue
(#4166)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants