Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign the uninstaller, too #540

Closed
dscho opened this issue Nov 20, 2015 · 3 comments
Closed

Sign the uninstaller, too #540

dscho opened this issue Nov 20, 2015 · 3 comments
Assignees
@dscho
Labels
enhancement installer

Comments

@dscho
Copy link
Member

dscho commented Nov 20, 2015

InnoSetup has a helpful option to sign the uninstaller, let's use that option. Of course, while at it, we could use InnoSetup's option to sign the installer instead of doing that manually, afterwards. So let's do that, too.
@dscho dscho self-assigned this Nov 20, 2015
@shiftkey
Copy link

@dscho
Copy link
Member Author

dscho commented Nov 23, 2015

@shiftkey LOL. You crack me up ;-)

dscho added a commit to git-for-windows/build-extra that referenced this issue Feb 1, 2016
@dscho
installer: allow configuring a signtool from the command-line
2871154 
By passing the /DSIGNTOOL command-line option (i.e. defining the
SIGNTOOL constant) and configuring a signtool via the /Ssigntool=...
option, we can now tell InnoSetup to sign the .exe.

InnoSetup's 'SignUninstaller' setting defaults to 'yes' in this case (see
http://www.innosetup.com/ishelp/topic_setup_signeduninstaller.htm for
details), therefore this change also signs the uninstaller and addresses
git-for-windows/git#540 implicitly.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Member Author

dscho commented Feb 1, 2016

Fixed via git-for-windows/build-extra@2871154

@dscho dscho closed this as completed Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dscho dscho

Labels
enhancement installer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dscho @shiftkey