Let's add an install option to turn on core.symlinks
#921
Assignees
Milestone
Comments
dscho
added a commit
to dscho/build-extra
that referenced
this issue
Nov 1, 2016
It *is* possible to permit non-administrators to create symbolic links. Let's make that option more visible by adding it to the installer. This addresses git-for-windows/git#921 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to git-for-windows/build-extra
that referenced
this issue
Nov 1, 2016
It *is* possible to permit non-administrators to create symbolic links. Let's make that option more visible by adding it to the installer. This addresses git-for-windows/git#921 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to git-for-windows/build-extra
that referenced
this issue
Nov 1, 2016
There is [now an explicit option for symbolic link support](git-for-windows/git#921), including a link to a more verbose explanation of the issue. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It is possible to allow users other than administrators to create symlinks, via modifying the corresponding group policy.
So let's offer this as an option on the "advanced option" page, and for extra goodness, let's use InnoSetup's
ExecAsOriginalUser()function to test whether the calling user account is permitted to create symbolic links.We may need to be careful to handle the case where the installer is run from an elevated account to begin with, in which case the test would be meaningless. We should detect that situation and fall back to the previously chosen setting, defaulting to "false".
Granted, the group policy could be changed later, or other users who lack the permission may run into trouble, but we do need to trust people who run the installer to know what they are doing.
The text was updated successfully, but these errors were encountered: