fixup! Win32: symlink: add support for symlinks to directories #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the way how directory symlinks are detected by trying to open the link's target instead of the link itself. It seems that Windows 10 1803 (April 2018 Update) does not allow to call CreateFile on a link of a wrong type. If a file symlink points to a directory an attempt to open it with CreateFile causes an ERROR_ACCESS_DENIED. This behavior is different in previous version of Windows 10 (CreateFile opens the incorrect link without complaining), that's why it worked fine before. This fixes #1646 Signed-off-by: Michał Dudak <michal.dudak@gmail.com>
|
Perfect, thanks! |
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
May 3, 2018
Git for Windows [now creates directory symlinks correctly](git-for-windows/git#1651) when asked to. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1646 as described in the issue.