gc --auto: release pack files before auto packing #1769
Conversation
Teach gc --auto to release pack files before auto packing the repository to prevent failures when removing them. Also teach the test 'fetching with auto-gc does not lock up' to complain when it is no longer triggering an auto packing of the repository. Fixes git-for-windows#500 Signed-off-by: Kim Gybels <kgybels@infogroep.be> Signed-off-by: Junio C Hamano <gitster@pobox.com>
|
/cc @kgybels (I would like to make you the reviewer once you accept, and then you should be able to merge this PR, maybe after the build finishes?). |
|
@dscho Why do we need to merge this to |
The idea is to have it in Git for Windows early, in particular in a snapshot, so that the bug reporter can verify that the issue is fixed. You would not believe how many times we took fixes, and they were untested, and the new Git for Windows version came out, and the bug was not fixed. Of course, this also happened despite snapshots to test, and the bug reporters simply didn't. But I want us to at least offer this, as it is then not our fault that the fix was not correct.
The next merging rebase will drop it automatically, as it is already upstream. |
Teach gc --auto to release pack files before auto packing the repository
to prevent failures when removing them.
Also teach the test 'fetching with auto-gc does not lock up' to complain
when it is no longer triggering an auto packing of the repository.
Fixes #500