Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix t0001 when the current working directory differs in case from the canonical form #1859

Merged
merged 2 commits into from
Oct 17, 2018

Conversation

dscho
Copy link
Member

@dscho dscho commented Oct 2, 2018

It's an obscure case, granted, but @jamill encountered it.

The /dev/null trick does not even work... It makes `git diff --no-index`
fail because it tries to access the XDG config as
`\\.\GLOBALROOT\Device\Null/.config/git/config`, which is not even a
valid path (and therefore the `access_error_is_ok()` check fails).

Let's just use a known-missing path on Windows.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho requested a review from jamill October 2, 2018 20:08
On a case-insensitive filesystem, such as HFS+ or NTFS, it is possible
that the idea Bash has of the current directory differs in case from
what Git thinks it is. That's totally okay, though, and we should not
expect otherwise.

Reported by Jameson Miller.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Member Author

dscho commented Oct 11, 2018

@jamill ping?

@dscho dscho merged commit d4f95fc into git-for-windows:master Oct 17, 2018
@dscho dscho deleted the funny-cased-cwd branch October 17, 2018 08:15
dscho added a commit to dscho/git that referenced this pull request Nov 19, 2018
Fix t0001 when the current working directory differs in case from the canonical form
dscho added a commit to dscho/git that referenced this pull request Nov 20, 2018
Fix t0001 when the current working directory differs in case from the canonical form
dscho added a commit that referenced this pull request Nov 21, 2018
Fix t0001 when the current working directory differs in case from the canonical form
dscho added a commit to dscho/git that referenced this pull request Nov 23, 2018
Fix t0001 when the current working directory differs in case from the canonical form
dscho added a commit to dscho/git that referenced this pull request Nov 30, 2018
Fix t0001 when the current working directory differs in case from the canonical form
dscho added a commit to dscho/git that referenced this pull request Dec 1, 2018
Fix t0001 when the current working directory differs in case from the canonical form
dscho added a commit to dscho/git that referenced this pull request Dec 9, 2018
Fix t0001 when the current working directory differs in case from the canonical form
dscho added a commit to dscho/git that referenced this pull request Dec 15, 2018
Fix t0001 when the current working directory differs in case from the canonical form
dscho added a commit to dscho/git that referenced this pull request Feb 7, 2019
Fix t0001 when the current working directory differs in case from the canonical form
dscho added a commit to dscho/git that referenced this pull request Feb 7, 2019
Fix t0001 when the current working directory differs in case from the canonical form
dscho added a commit that referenced this pull request Jun 8, 2019
Fix t0001 when the current working directory differs in case from the canonical form
git-for-windows-ci pushed a commit that referenced this pull request Jun 8, 2019
Fix t0001 when the current working directory differs in case from the canonical form
dscho added a commit that referenced this pull request Jun 8, 2019
Fix t0001 when the current working directory differs in case from the canonical form
dscho added a commit that referenced this pull request Jun 8, 2019
Fix t0001 when the current working directory differs in case from the canonical form
dscho added a commit that referenced this pull request Jun 8, 2019
Fix t0001 when the current working directory differs in case from the canonical form
git-for-windows-ci pushed a commit that referenced this pull request Jun 10, 2019
Fix t0001 when the current working directory differs in case from the canonical form
git-for-windows-ci pushed a commit that referenced this pull request Jun 11, 2019
Fix t0001 when the current working directory differs in case from the canonical form
git-for-windows-ci pushed a commit that referenced this pull request Jun 12, 2019
Fix t0001 when the current working directory differs in case from the canonical form
git-for-windows-ci pushed a commit that referenced this pull request Jun 13, 2019
Fix t0001 when the current working directory differs in case from the canonical form
git-for-windows-ci pushed a commit that referenced this pull request Jun 13, 2019
Fix t0001 when the current working directory differs in case from the canonical form
dscho added a commit that referenced this pull request Jun 17, 2019
Fix t0001 when the current working directory differs in case from the canonical form
git-for-windows-ci pushed a commit that referenced this pull request Jun 18, 2019
Fix t0001 when the current working directory differs in case from the canonical form
git-for-windows-ci pushed a commit that referenced this pull request Jun 18, 2019
Fix t0001 when the current working directory differs in case from the canonical form
dscho added a commit that referenced this pull request Jun 18, 2019
Fix t0001 when the current working directory differs in case from the canonical form
dscho added a commit that referenced this pull request Jun 19, 2019
Fix t0001 when the current working directory differs in case from the canonical form
dscho added a commit that referenced this pull request Jun 21, 2019
Fix t0001 when the current working directory differs in case from the canonical form
git-for-windows-ci pushed a commit that referenced this pull request Jun 21, 2019
Fix t0001 when the current working directory differs in case from the canonical form
git-for-windows-ci pushed a commit that referenced this pull request Jun 21, 2019
Fix t0001 when the current working directory differs in case from the canonical form
git-for-windows-ci pushed a commit that referenced this pull request Jun 21, 2019
Fix t0001 when the current working directory differs in case from the canonical form
git-for-windows-ci pushed a commit that referenced this pull request Jun 27, 2019
Fix t0001 when the current working directory differs in case from the canonical form
git-for-windows-ci pushed a commit that referenced this pull request Jul 8, 2019
Fix t0001 when the current working directory differs in case from the canonical form
git-for-windows-ci pushed a commit that referenced this pull request Jul 8, 2019
Fix t0001 when the current working directory differs in case from the canonical form
git-for-windows-ci pushed a commit that referenced this pull request Jul 11, 2019
Fix t0001 when the current working directory differs in case from the canonical form
git-for-windows-ci pushed a commit that referenced this pull request Jul 23, 2019
Fix t0001 when the current working directory differs in case from the canonical form
git-for-windows-ci pushed a commit that referenced this pull request Jul 25, 2019
Fix t0001 when the current working directory differs in case from the canonical form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants