Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fscache: add fscache hit statistics #1910

Merged
merged 1 commit into from
Nov 16, 2018
Merged

fscache: add fscache hit statistics #1910

merged 1 commit into from
Nov 16, 2018

Conversation

benpeart
Copy link

@benpeart benpeart commented Nov 1, 2018

Track fscache hits and misses for lstat and opendir requests. Reporting of statistics is done when the cache is disabled for the last time and freed and is only reported if GIT_TRACE_FSCACHE is set.

Sample output is:

11:33:11.836428 compat/win32/fscache.c:433 fscache: lstat 3775, opendir 263, total requests/misses 4052/269

Signed-off-by: Ben Peart benpeart@microsoft.com

dscho
dscho requested changes Nov 5, 2018
View reviewed changes
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. With that one change to limit those new variables' scope, I think we're good to go!

compat/win32/fscache.c Outdated Show resolved Hide resolved
@benpeart
fscache: add fscache hit statistics
052813a 
Track fscache hits and misses for lstat and opendir requests.  Reporting of
statistics is done when the cache is disabled for the last time and freed
and is only reported if GIT_TRACE_FSCACHE is set.

Sample output is:

11:33:11.836428 compat/win32/fscache.c:433 fscache: lstat 3775, opendir 263, total requests/misses 4052/269

Signed-off-by: Ben Peart <benpeart@microsoft.com>
@weekly-digest weekly-digest bot mentioned this pull request Nov 11, 2018
Closed
@dscho dscho merged commit 8d05b91 into git-for-windows:master Nov 16, 2018
@dscho
Copy link
Member

dscho commented Nov 16, 2018

Thank you!

@dscho dscho added this to the v2.19.1(2) milestone Nov 16, 2018
@weekly-digest weekly-digest bot mentioned this pull request Nov 18, 2018
Closed
dscho added a commit to dscho/git that referenced this pull request Nov 19, 2018
@dscho
Merge pull request git-for-windows#1910 from benpeart/fscache_statist…
438314b 
…ics-gfw

fscache: add fscache hit statistics
dscho added a commit to dscho/git that referenced this pull request Nov 20, 2018
@dscho
Merge pull request git-for-windows#1910 from benpeart/fscache_statist…
ea1df4e 
…ics-gfw

fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Nov 21, 2018
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
c2e8fb3 
fscache: add fscache hit statistics
dscho added a commit to dscho/git that referenced this pull request Nov 23, 2018
@dscho
Merge pull request git-for-windows#1910 from benpeart/fscache_statist…
814d563 
…ics-gfw

fscache: add fscache hit statistics
@weekly-digest weekly-digest bot mentioned this pull request Nov 25, 2018
Closed
dscho added a commit to dscho/git that referenced this pull request Nov 30, 2018
@dscho
Merge pull request git-for-windows#1910 from benpeart/fscache_statist…
c93ed5e 
…ics-gfw

fscache: add fscache hit statistics
dscho added a commit to dscho/git that referenced this pull request Dec 1, 2018
@dscho
Merge pull request git-for-windows#1910 from benpeart/fscache_statist…
17a920d 
…ics-gfw

fscache: add fscache hit statistics
dscho added a commit to dscho/git that referenced this pull request Dec 9, 2018
@dscho
Merge pull request git-for-windows#1910 from benpeart/fscache_statist…
a7a949e 
…ics-gfw

fscache: add fscache hit statistics
dscho added a commit to dscho/git that referenced this pull request Dec 15, 2018
@dscho
Merge pull request git-for-windows#1910 from benpeart/fscache_statist…
80a78c5 
…ics-gfw

fscache: add fscache hit statistics
dscho added a commit to dscho/git that referenced this pull request Feb 7, 2019
@dscho
Merge pull request git-for-windows#1910 from benpeart/fscache_statist…
9370b56 
…ics-gfw

fscache: add fscache hit statistics
dscho added a commit to dscho/git that referenced this pull request Feb 7, 2019
@dscho
Merge pull request git-for-windows#1910 from benpeart/fscache_statist…
d9f8dcf 
…ics-gfw

fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Oct 11, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
7e1ff23 
fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Oct 20, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
555cae9 
fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Oct 20, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
bc2692e 
fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Oct 21, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
f5d3456 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Oct 21, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
a5fc934 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Oct 21, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
23f911d 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Oct 22, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
fe9feac 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Oct 22, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
0f18d31 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Oct 22, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
49d8473 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Oct 22, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
0a206f0 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Oct 22, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
39f5463 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Oct 22, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
e23f651 
fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Oct 23, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
b67ba97 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Oct 25, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
edc1665 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Oct 25, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
c1baf75 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Oct 25, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
4d06b71 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Oct 30, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
5bf9fff 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Nov 1, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
a038144 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Nov 6, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
6701c72 
fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Nov 22, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
c1eab4a 
fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Nov 22, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
770bb69 
fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Nov 22, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
5ce177e 
fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Nov 22, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
6082719 
fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Nov 22, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
8394720 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Nov 25, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
0140853 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Nov 25, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
bbbc233 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Nov 25, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
3872add 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Nov 25, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
ac232c4 
fscache: add fscache hit statistics
dscho added a commit to dscho/git that referenced this pull request Nov 25, 2024
@dscho
Merge pull request git-for-windows#1910 from benpeart/fscache_statist…
0454a46 
…ics-gfw

fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Nov 25, 2024
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
28a527d 
fscache: add fscache hit statistics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dscho dscho dscho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.19.2
Development

Successfully merging this pull request may close these issues.
2 participants
@benpeart @dscho