Resolving ERROR_INVALID_PARAMETER issue with some network storage sol… #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
requested changes
Jul 4, 2019
compat/mingw.c
Outdated
| return errno = err_win_to_posix(GetLastError()), -1; | ||
|
|
||
| if (handle == INVALID_HANDLE_VALUE) { | ||
|
|
compat/mingw.c
Outdated
|
|
||
| DWORD err = GetLastError(); | ||
|
|
||
| // Some network storage solutions (e.g. Isilon) might return ERROR_INVALID_PARAMETER |
There was a problem hiding this comment.
In Git's source code, there are only /* ... */ style comments, not C++/C99 ones. Please change this comment accordingly.
There was a problem hiding this comment.
I indeed should have used the same style that was already used in the existing code
| @@ -661,8 +661,18 @@ static int mingw_open_append(wchar_t const *wfilename, int oflags, ...) | |||
| handle = CreateFileW(wfilename, FILE_APPEND_DATA, | |||
There was a problem hiding this comment.
The commit message needs a little bit of work... Just imagine that you yourself stumble over this commit in six months from now, not remembering what you did, but wanting to figure it out.
To that end, the Git project tries to enforce very informative commit messages, in a somewhat idiomatic form.
In particular, the commit message should focus a bit more on the "Why?" and to a lesser extent the "What?" than the "How?".
In this case, I would strongly suggest something along those lines:
mingw: cope with the Isilon network file system
On certain network filesystems (*cough* Isilon), when the directory in
question is missing, `raceproof_create_file()` fails with an
`ERROR_INVALID_PARAMETER` instead of an `ERROR_PATH_NOT_FOUND`.
Since it is highly unlikely that we produce such an error by mistake
(the parameters we pass are fairly benign), we can be relatively certain
that the directory is missing in this instance. So let's just translate
that error automagically.
This fixes https://github.com/git-for-windows/git/issues/1345.
Signed-off-by: ...
There was a problem hiding this comment.
I will reuse most of your example, if you are fine by that. I do not what to re-invent the wheel as we say in Dutch :). I personally only work on small scale projects, but I fully understand the more verbose commit.
|
The requested changes should have been pushed. |
Could you please squash the two commits into one, using the second commits' message? The easiest will be using Thank you! |
|
Done |
|
Would you kindly use your real name in the Signed-off-by: line? It is required by the Git project, and I won't be able to upstream this patch without it. Thanks. |
|
I admire your patience with me. Done again. |
On certain network filesystems (currently encounterd with Isilon, but in theory more network storage solutions could be causing the same issue), when the directory in question is missing, `raceproof_create_file()` fails with an `ERROR_INVALID_PARAMETER` instead of an `ERROR_PATH_NOT_FOUND`. Since it is highly unlikely that we produce such an error by mistake (the parameters we pass are fairly benign), we can be relatively certain that the directory is missing in this instance. So let's just translate that error automagically. This fixes #1345. Signed-off-by: Nathan Sanders <spekbukkem@gmail.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
May I return the compliment? You analyzed this really well, and I have seen few Git for Windows contributors with your amount of grit.
Thank you. I amended this with my Sign-off after aligning the white-space, and will merge now. Thanks so much! |
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 8, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 8, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 8, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 8, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 9, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 10, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 11, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
dscho
added a commit
that referenced
this pull request
Jul 11, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 11, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
dscho
added a commit
that referenced
this pull request
Jul 12, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 12, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 12, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
dscho
added a commit
that referenced
this pull request
Jul 15, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 8, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 8, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 8, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 9, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 9, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 9, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 12, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 12, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 12, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 12, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 14, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 14, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 16, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
dscho
added a commit
that referenced
this pull request
Aug 22, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 23, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 2, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
dscho
added a commit
that referenced
this pull request
Sep 24, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 30, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
dscho
added a commit
that referenced
this pull request
Oct 2, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 7, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 17, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
dscho
added a commit
that referenced
this pull request
Oct 21, 2019
Resolving ERROR_INVALID_PARAMETER issue with some network storage sol…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for unexpected error (ERROR_INVALID_PARAMETER) instead of ERROR_PATH_NOT_FOUND on certain network storage during creation of files for which the full path does not exist yet.