Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs #2351

Merged
merged 2 commits into from
Oct 7, 2019
Merged

Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs #2351

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5f4a0c
vcpkg_install: detect lack of Git
PhilipOakley Oct 6, 2019
6613228
vcpkg_install: add comment regarding slow network connections
PhilipOakley Oct 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions compat/vcbuild/vcpkg_install.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@ REM ================================================================

dir vcpkg\vcpkg.exe >nul 2>nul && GOTO :install_libraries

git.exe version 2>nul
IF ERRORLEVEL 1 (
echo "***"
echo "Git not found. Please adjust you CMD path or Git install option."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo:

s/you/your/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 504b50d

echo "***"
EXIT /B 1 )

echo Fetching vcpkg in %cwd%vcpkg
git.exe clone https://github.com/Microsoft/vcpkg vcpkg
IF ERRORLEVEL 1 ( EXIT /B 1 )
Expand Down Expand Up @@ -73,6 +80,12 @@ REM ================================================================
:sub__install_one
echo Installing package %1...

REM vcpkg may not be reliable on slow, intermittent or proxy
REM connections, see e.g.
REM https://social.msdn.microsoft.com/Forums/windowsdesktop/en-US/4a8f7be5-5e15-4213-a7bb-ddf424a954e6/winhttpsendrequest-ends-with-12002-errorhttptimeout-after-21-seconds-no-matter-what-timeout?forum=windowssdk
REM which explains the hidden 21 second timeout
REM (last post by Dave : Microsoft - Windows Networking team)

.\vcpkg.exe install %1:%arch%
IF ERRORLEVEL 1 ( EXIT /B 1 )

Expand Down