Fix the vs-build job so that CI builds pass again #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dennisameling thank you for doing the hard work on figuring this one out! |
Something changed in `vcpkg` (which we use in our Visual C++ build to provide the dependencies such as libcurl) and our `vs-build` job started failing in CI. The reason is that we had a work-around in place to help CMake find iconv, and this work-around is neither needed nor does it work anymore. For the full discussion with the vcpkg project, see this comment: microsoft/vcpkg#14780 (comment) Signed-off-by: Dennis Ameling <dennis@dennisameling.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
vs-build-and-libiconv
branch
from
00042b2 to
9310b46
Compare
dscho
changed the title
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 4, 2020
Fix the vs-build job so that CI builds pass again
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 4, 2020
Fix the vs-build job so that CI builds pass again
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 4, 2020
Fix the vs-build job so that CI builds pass again
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 4, 2020
Fix the vs-build job so that CI builds pass again
|
Companion PRs: gitgitgadget#805 and microsoft#300. |
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 4, 2020
Fix the vs-build job so that CI builds pass again
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 4, 2020
Fix the vs-build job so that CI builds pass again
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 4, 2020
Fix the vs-build job so that CI builds pass again
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 4, 2020
Fix the vs-build job so that CI builds pass again
Merged
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 9, 2020
Fix the vs-build job so that CI builds pass again
dscho
added a commit
that referenced
this pull request
Dec 10, 2020
Fix the vs-build job so that CI builds pass again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix was originally developed in #2915, but should probably be fast-tracked.