forked from git/git
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix double .exe suffixes in CMakeLists.txt #2966
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
dennisameling
changed the title
Fix double .exe suffixes
Fix double .exe suffixes in CMakeLists.txt
Jan 5, 2021
By mistake, the `.exe` extension is appended _twice_ when installing the dashed executables into `libexec/git-core/` on Windows (the extension is already appended when adding items to the `git_links` list in the `#Creating hardlinks` section). Signed-off-by: Dennis Ameling <dennis@dennisameling.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Thank you! I reworded the commit message to make it more likely that the patch will be accepted upstream (but I want to wait with that until we are sure that there are no further problems lurking there). |
dscho
added a commit
that referenced
this pull request
Jan 6, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 7, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 8, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 8, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 8, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 8, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 8, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 9, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 14, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 14, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 14, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 14, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 14, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 15, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 15, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 15, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 15, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 15, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 15, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 18, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 18, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 18, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 20, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 20, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 24, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 24, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 24, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 24, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Mar 25, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 25, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 26, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 26, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 26, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
to dscho/git
that referenced
this pull request
Mar 27, 2021
…-exe Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 27, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Mar 29, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Mar 29, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Mar 29, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Mar 29, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Mar 29, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Mar 29, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 30, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 30, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 31, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 31, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 31, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 3, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 4, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Apr 7, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Apr 8, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Apr 10, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Apr 13, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
May 19, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
May 22, 2021
Fix double .exe suffixes in CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2965
If you want to verify this yourself, please follow the steps from #2915 (comment)