Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double .exe suffixes in CMakeLists.txt #2966

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Fix double .exe suffixes in CMakeLists.txt #2966

merged 1 commit into from
Jan 5, 2021

Conversation

dennisameling
Copy link

@dennisameling dennisameling commented Jan 5, 2021

Fixes #2965

If you want to verify this yourself, please follow the steps from #2915 (comment)

@dennisameling dennisameling changed the title Fix double .exe suffixes Fix double .exe suffixes in CMakeLists.txt Jan 5, 2021
By mistake, the `.exe` extension is appended _twice_ when installing the
dashed executables into `libexec/git-core/` on Windows (the extension is
already appended when adding items to the `git_links` list in the
`#Creating hardlinks` section).

Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Member

dscho commented Jan 5, 2021

Thank you! I reworded the commit message to make it more likely that the patch will be accepted upstream (but I want to wait with that until we are sure that there are no further problems lurking there).

@dscho dscho merged commit fde3e95 into git-for-windows:main Jan 5, 2021
dscho added a commit that referenced this pull request Jan 6, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 7, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 8, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 8, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 8, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 8, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 8, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 9, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 14, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 14, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 14, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 14, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 14, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 15, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 15, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 15, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 15, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 15, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 15, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 18, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 18, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 18, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 20, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Jan 20, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci pushed a commit that referenced this pull request Mar 24, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci pushed a commit that referenced this pull request Mar 24, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci pushed a commit that referenced this pull request Mar 24, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci pushed a commit that referenced this pull request Mar 24, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Mar 25, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci pushed a commit that referenced this pull request Mar 25, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci pushed a commit that referenced this pull request Mar 26, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci pushed a commit that referenced this pull request Mar 26, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci pushed a commit that referenced this pull request Mar 26, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit to dscho/git that referenced this pull request Mar 27, 2021
…-exe

Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci pushed a commit that referenced this pull request Mar 27, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Mar 29, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Mar 29, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Mar 29, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Mar 29, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Mar 29, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Mar 29, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci pushed a commit that referenced this pull request Mar 30, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci pushed a commit that referenced this pull request Mar 30, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci pushed a commit that referenced this pull request Mar 31, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci pushed a commit that referenced this pull request Mar 31, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci pushed a commit that referenced this pull request Mar 31, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci pushed a commit that referenced this pull request Apr 3, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci pushed a commit that referenced this pull request Apr 4, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Apr 7, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Apr 8, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Apr 10, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request Apr 13, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request May 19, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho added a commit that referenced this pull request May 22, 2021
Fix double .exe suffixes in CMakeLists.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.exe.exe files generated when doing MSVC build
2 participants