Fix "BUG: refs/files-backend.c:465: returning non-zero -1, should have set myerr!" #3678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since df3458e (refs API: make parse_loose_ref_contents() not set errno, 2021-10-16), `files_read_raw_ref()` assumes that `errno` is always set to a non-zero value upon failure. It even goes so far as to hard-code that assumption in a `BUG()` when that assumption is not met, rather than fail gracefully. According to https://pubs.opengroup.org/onlinepubs/9699919799/functions/lstat.html, `lstat()` shall indeed set `errno` upon failure, and https://pubs.opengroup.org/onlinepubs/9699919799/functions/errno.html indicates that indeed, the code may rely on `errno` being set to a non-zero value upon failure. In `fscache_lstat()`, we did not set `errno` upon a cache miss (which indicates that the item did not exist at the time the `lstat()` values were cached), and therefore we now trigger this problem all the time. Let's set `errno=ENOENT` when no entry was found. This fixes git-for-windows#3674 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
1 task
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Feb 1, 2022
A [bug](git-for-windows/git#3674) in FSCache that triggered by a patch that made it into Git for Windows v2.35.0 [was fixed](git-for-windows/git#3678). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3674.