Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common-main.c: fflush stdout buffer when exit #4901

Merged
merged 1 commit into from
Apr 12, 2024
Merged

common-main.c: fflush stdout buffer when exit #4901

merged 1 commit into from
Apr 12, 2024

Conversation

chengzhuo5
Copy link

No description provided.

@chengzhuo5 chengzhuo5 mentioned this pull request Apr 8, 2024
Closed
1 task
dscho
dscho approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great finding, and obviously-good fix!

You may want to follow the advice in https://github.blog/2022-06-30-write-better-commits-build-better-projects/ to align the commit message's style with Git's conventions.

common-main.c Outdated Show resolved Hide resolved
common-main.c Outdated Show resolved Hide resolved
@chengzhuo5 chengzhuo5 requested a review from dscho April 9, 2024 02:03
@chengzhuo5 @dscho
common-main.c: fflush stdout buffer upon exit
ff86989 
By default, the buffer type of Windows' `stdout` is unbuffered (_IONBF),
and there is no need to manually fflush `stdout`.

But some programs, such as the Windows Filtering Platform driver
provided by the security software, may change the buffer type of
`stdout` to full buffering. This nees `fflush(stdout)` to be called
manually, otherwise there will be no output to `stdout`.

Signed-off-by: MinarKotonoha <chengzhuo5@qq.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho added this to the Next release milestone Apr 12, 2024
@dscho dscho merged commit 79cd17f into git-for-windows:main Apr 12, 2024
41 checks passed
git-for-windows-ci pushed a commit that referenced this pull request Apr 12, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
df36353
github-actions bot pushed a commit to git-for-windows/build-extra that referenced this pull request Apr 12, 2024
Add a release note (bug)
9b63431 
Apparently some anti-malware programs fiddle with the mode of `stdout`
which [can lead to problems because expected output is
missing](git-for-windows/git#4890), which [was
fixed](git-for-windows/git#4901).

Signed-off-by: gitforwindowshelper[bot] <gitforwindowshelper-bot@users.noreply.github.com>
git-for-windows-ci pushed a commit that referenced this pull request Apr 12, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
09ddf45
@dscho
Copy link
Member

dscho commented Apr 12, 2024

Thank you @chengzhuo5 for going the extra mile to fix the issue!

git-for-windows-ci pushed a commit that referenced this pull request Apr 12, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
a4681d3
git-for-windows-ci pushed a commit that referenced this pull request Apr 12, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
0a1ae91
git-for-windows-ci pushed a commit that referenced this pull request Apr 12, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
bc1ef5c
git-for-windows-ci pushed a commit that referenced this pull request Apr 12, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
f4d64b9
git-for-windows-ci pushed a commit that referenced this pull request Apr 12, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
0f58bc0
git-for-windows-ci pushed a commit that referenced this pull request Apr 12, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
9635062
dscho added a commit that referenced this pull request Apr 14, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
f5633a2
git-for-windows-ci pushed a commit that referenced this pull request Apr 15, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
8df58c6
git-for-windows-ci pushed a commit that referenced this pull request Apr 15, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
4caee08
git-for-windows-ci pushed a commit that referenced this pull request Apr 15, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
db833d1
git-for-windows-ci pushed a commit that referenced this pull request Apr 16, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
5d703d6
git-for-windows-ci pushed a commit that referenced this pull request Apr 16, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
6f7d49a
git-for-windows-ci pushed a commit that referenced this pull request Apr 17, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
66f703d
git-for-windows-ci pushed a commit that referenced this pull request Apr 17, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
b4333ed
git-for-windows-ci pushed a commit that referenced this pull request Apr 17, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
db58249
git-for-windows-ci pushed a commit that referenced this pull request Oct 8, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
00676d5
dscho added a commit that referenced this pull request Oct 8, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
b6fae8a
dscho added a commit that referenced this pull request Oct 8, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
b8df26b
dscho added a commit that referenced this pull request Oct 8, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
5628988
git-for-windows-ci pushed a commit that referenced this pull request Oct 9, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
1219fbc
git-for-windows-ci pushed a commit that referenced this pull request Oct 9, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
7b984bb
git-for-windows-ci pushed a commit that referenced this pull request Oct 9, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
f8eeb8f
git-for-windows-ci pushed a commit that referenced this pull request Oct 9, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
7e4c611
dscho added a commit that referenced this pull request Oct 9, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
8066fd7
dscho added a commit that referenced this pull request Oct 9, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
a7fb991
git-for-windows-ci pushed a commit that referenced this pull request Oct 10, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
5bfa259
git-for-windows-ci pushed a commit that referenced this pull request Oct 11, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
db0a038
dscho added a commit that referenced this pull request Oct 11, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
50e961f
dscho added a commit that referenced this pull request Oct 11, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
d3d236b
dscho added a commit that referenced this pull request Oct 20, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
7cf6c2b
dscho added a commit that referenced this pull request Oct 21, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
55c7b98
git-for-windows-ci pushed a commit that referenced this pull request Oct 21, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
9dcee06
git-for-windows-ci pushed a commit that referenced this pull request Oct 21, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
84906e6
git-for-windows-ci pushed a commit that referenced this pull request Oct 22, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
caf9111
git-for-windows-ci pushed a commit that referenced this pull request Oct 22, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
f054d8c
git-for-windows-ci pushed a commit that referenced this pull request Oct 22, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
f07c19b
git-for-windows-ci pushed a commit that referenced this pull request Oct 22, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
70a9eb6
git-for-windows-ci pushed a commit that referenced this pull request Oct 22, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
fc86d6f
git-for-windows-ci pushed a commit that referenced this pull request Oct 22, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
7729dbf
git-for-windows-ci pushed a commit that referenced this pull request Oct 25, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
a0f749c
git-for-windows-ci pushed a commit that referenced this pull request Oct 25, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
87bd2ab
git-for-windows-ci pushed a commit that referenced this pull request Oct 25, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
591e1a1
git-for-windows-ci pushed a commit that referenced this pull request Oct 30, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
e93b9a2
git-for-windows-ci pushed a commit that referenced this pull request Nov 1, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
32e8ba1
git-for-windows-ci pushed a commit that referenced this pull request Nov 6, 2024
@dscho
common-main.c: fflush stdout buffer when exit (#4901)
f0c2e6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dscho dscho Awaiting requested review from dscho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.45.0
Development

Successfully merging this pull request may close these issues.
2 participants
@chengzhuo5 @dscho