Fix build with GCC v14.1 #4962
Merged
Fix build with GCC v14.1 #4962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows compiler suddenly started complaining that calloc(3) takes its arguments in <nmemb, size> order. Indeed, there are many calls that has their arguments in a _wrong_ order. Fix them all. A sample breakage can be seen at https://github.com/git/git/actions/runs/9046793153/job/24857988702#step:4:272 Signed-off-by: Junio C Hamano <gitster@pobox.com>
* jc/compat-regex-calloc-fix: compat/regex: fix argument order to calloc(3) This is a backport of 077c4e1 (Merge branch 'jc/compat-regex-calloc-fix' into next, 2024-05-13) to fix compile errors in Git for Windows' SDK since GCC was upgraded to v14.1.
The `__MINGW64__` constant is defined, surprise, surprise, only when
building for a 64-bit CPU architecture.
Therefore using it as a guard to define `_POSIX_C_SOURCE` (so that
`localtime_r()` is declared, among other functions) is not enough, we
also need to check `__MINGW32__`.
Technically, the latter constant is defined even for 64-bit builds. But
let's make things a bit easier to understand by testing for both
constants.
Making it so fixes this compile warning (turned error in GCC v14.1):
archive-zip.c: In function 'dos_time':
archive-zip.c:612:9: error: implicit declaration of function 'localtime_r';
did you mean 'localtime_s'? [-Wimplicit-function-declaration]
612 | localtime_r(&time, &tm);
| ^~~~~~~~~~~
| localtime_s
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
that referenced
this pull request
May 27, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
dscho
added a commit
that referenced
this pull request
May 27, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
dscho
added a commit
that referenced
this pull request
May 27, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 28, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 28, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
dscho
added a commit
to dscho/git
that referenced
this pull request
Jun 3, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses git-for-windows#4953.
dscho
added a commit
that referenced
this pull request
Jun 3, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
dscho
added a commit
that referenced
this pull request
Jun 3, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jun 3, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jun 3, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jun 4, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jun 4, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jun 4, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jun 4, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jun 4, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jun 5, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jun 5, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jun 6, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jun 6, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jun 6, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jun 6, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jun 6, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
dscho
added a commit
that referenced
this pull request
Jun 6, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 2, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 2, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 2, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 2, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 2, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 2, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
dscho
added a commit
that referenced
this pull request
Jul 2, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
dscho
added a commit
that referenced
this pull request
Jul 2, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
dscho
added a commit
that referenced
this pull request
Jul 2, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 3, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 3, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 4, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 4, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 4, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 4, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 9, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 9, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 10, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 10, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 10, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 10, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 10, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
dscho
added a commit
that referenced
this pull request
Jul 10, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 10, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 11, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
dscho
added a commit
that referenced
this pull request
Jul 11, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 11, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 11, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 12, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 12, 2024
The GCC v14.1 upgrade broke the build of `git-artifacts`. Partially, this has been fixed upstream already, but the i686 build requires a separate fix. This addresses #4953.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GCC v14.1 upgrade broke the build of
git-artifacts. Partially, this has been fixed upstream already, but the i686 build requires a separate fix.This addresses #4953.