Fix incorrect code page in console title

[gdh1995]

WriteConsoleA always follows the current code page of a console window, so it's not suitable to pass a multi-byte string in get_ttyp ()->term_code_page to it directly.

This PR turns to WriteConsoleW so that most characters will be translated "as is", and I've tested it on Win 10 v2004 (CMD: ver 10.0.19041.388).

This PR will fix git-for-windows/git#2738 .

[dscho]

Interesting find!

However, wouldn't it make sense to change that call to WriteConsoleA() in wpbuf's send() method to convert to Unicode and call WriteConsoleW() instead?

Also, since this is safely in the non-MSYS2 part of Cygwin, have you considered contributing this to cygwin-patches?

[gdh1995]

Um, I'm not sure what it will influence if update wpbuf.send directly. Maybe it will make most code work better, but I have no enough knowledge about how to test it and what is expected. I don't know how to use cygwin-patches, either.

So, please feel free to replace this PR with some other commits of yours.

[dscho]

I'm not sure what it will influence if update wpbuf.send directly.

If your patch is correct, it will only make things better, not worse.

However, the current patch does make things worse because it fixes the encoding issue only in one location, by completely re-implementing the send() method, leaving the send() method itself broken.

So, please feel free to replace this PR with some other commits of yours.

I do not have the time.

[dscho]

Hmm. Having had a look at the callers of send(), I agree that this would be too dangerous.

Maybe you want to take this discussion to Cygwin, maybe by sending your patch as an "RFC" to https://cygwin.com/mailman/listinfo/cygwin-patches/?

[gdh1995]

OK, I'll take a try on cygwin-patches

[dscho]

I cherry-picked Takashi's fix, and am building a new msys2-runtime package: https://dev.azure.com/Git-for-Windows/git/_build/results?buildId=61752&view=results