Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress FAST_CWD warnings on ARM64 #33

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Suppress FAST_CWD warnings on ARM64 #33

merged 2 commits into from
Oct 11, 2021

Conversation

Alovchin91
Copy link

@Alovchin91 Alovchin91 commented Oct 9, 2021

This cherry-picks msys2/msys2-runtime@d77a022 and msys2/msys2-runtime@25d1543 so that Cygwin’s warning Couldn't compute FAST_CWD pointer is suppressed when running under x64 emulation on ARM64.

Addresses git-for-windows/git#3231

github-cygwin and others added 2 commits October 9, 2021 11:22
The previous patch is accidentally missing the declaration of
IsWow64Process2.  Add it belatedly.

Fixes: 1865a41cb383 ("Cygwin: suppress FAST_CWD warnings on ARM64")
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
The old check was insufficient: new insider preview builds of Windows
allow running x86_64 process on ARM64.  The IsWow64Process2 function
seems to be the intended way to figure this situation out.

Signed-off-by: Alexander Ovchinnikov <8490695+Alovchin91@users.noreply.github.com>
@dscho dscho merged commit 6524870 into git-for-windows:main Oct 11, 2021
@dscho
Copy link
Member

dscho commented Oct 11, 2021

Thank you! The build is running here.

@Alovchin91 Alovchin91 deleted the alovchin91/win-arm64-patch branch October 12, 2021 07:43
@dscho
Copy link
Member

dscho commented Oct 12, 2021

Thank you! The build is running here.

Actually, this run failed, and several runs after that, for a plethora of reasons. I fixed all of them and the new MSYS2 runtime version is now in Git for Windows' SDK. The next snapshot will have it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants