Use node-fetch for fetchJSONFromURL

[dennisameling]

As requested in git-for-windows/git#3040 (comment):

I have a feeling that this is hodgepodge code, and could be done much more elegantly

Actually, using node-fetch is a lot easier in this case. It makes mocking much easier as well. It's a very lightweight package that also adds convenience methods like res.json() to parse JSON responses.

[dscho]

Actually, using node-fetch is a lot easier in this case

Ironically, I did use it originally. But I was wary of adding yet more stuff that I do not really need.

Could you add an npm run build && npm run package commit, and compare the output size?

[dscho]

Very nice!

[dscho]

I only reordered the commits so that dist/ is once again updated only in the end, in a dedicated commit.

[dscho]

Oh, completely forgot: thank you so much!

[dscho]

@dennisameling look at this beauty: https://github.com/marketplace/actions/setup-git-for-windows-sdk

[dennisameling]

Love it!! 🚀 🎉