Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for git-lfs-ls-files' */- output. #2719

Merged
merged 1 commit into from
Nov 8, 2017

Conversation

bilke
Copy link
Contributor

@bilke bilke commented Nov 7, 2017

This functionality was introduced in 2082b26 but was not documented.

@bilke bilke changed the title Added documentation git-lfs-ls-files' */- output. Added documentation for git-lfs-ls-files' */- output. Nov 7, 2017
Copy link

@blanca92 blanca92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algo bien

Copy link

@blanca92 blanca92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algo bien

@technoweenie
Copy link
Contributor

Nice catch! Did you accept the CLA by chance? If you did, it's probably waiting for another CI run. I can push up a merge commit or something to trigger it.

@bilke
Copy link
Contributor Author

bilke commented Nov 7, 2017

Yes I accepted the CLA.

@mathstuf
Copy link
Contributor

mathstuf commented Nov 8, 2017

FYI, closing and reopening the PR will also retrigger CI runs.

@technoweenie technoweenie reopened this Nov 8, 2017
@technoweenie technoweenie merged commit 56f6c29 into git-lfs:master Nov 8, 2017
@atskhan
Copy link

atskhan commented Nov 9, 2017 via email

@bilke bilke deleted the patch-1 branch November 9, 2017 18:56
@tchebb
Copy link

tchebb commented Jan 9, 2019

Am I misunderstanding the wording, or is this documentation backwards? When I run git lfs ls-files, I see - for pointers and * for files with content.

@mathstuf
Copy link
Contributor

Agreed; the documentation is backwards. However, looking at the code, if the content size is the same as the pointer size, a false positive would be output. Might be worth another issue, but I'm not sure how important it is to fix.

@ttaylorr
Copy link
Contributor

Am I misunderstanding the wording, or is this documentation backwards?

Thanks for letting us know; the documentation was indeed backwards. I opened #3496 to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants