-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for git-lfs-ls-files' */- output. #2719
Conversation
This functionality was introduced in git-lfs@2082b26.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Algo bien
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Algo bien
Nice catch! Did you accept the CLA by chance? If you did, it's probably waiting for another CI run. I can push up a merge commit or something to trigger it. |
Yes I accepted the CLA. |
FYI, closing and reopening the PR will also retrigger CI runs. |
https://www.instagram.com/afreen3651/
Sent from my Samsung Galaxy smartphone.
-------- Original message --------From: risk danger olson <notifications@github.com> Date: 09/11/2017 1:43 am (GMT+05:30) To: git-lfs/git-lfs <git-lfs@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Subject: Re: [git-lfs/git-lfs] Added documentation for git-lfs-ls-files' */- output. (#2719)
Closed #2719.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/git-lfs/git-lfs","title":"git-lfs/git-lfs","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/git-lfs/git-lfs"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Closed #2719."}],"action":{"name":"View Pull Request","url":"#2719 (comment)"}}}
|
Am I misunderstanding the wording, or is this documentation backwards? When I run |
Agreed; the documentation is backwards. However, looking at the code, if the content size is the same as the pointer size, a false positive would be output. Might be worth another issue, but I'm not sure how important it is to fix. |
Thanks for letting us know; the documentation was indeed backwards. I opened #3496 to fix. |
This functionality was introduced in 2082b26 but was not documented.