.github/workflows: switch to actions/checkout@v2 #4795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actions/checkout workflow looks like it may have had a security-sensitive change to it in the latest v2. It doesn't look like it affects us, but let's update to be safe. Switch to actions/checkout@v2 everywhere and use the fetch-depth: 0 argument, which makes us fetch the entire history. This is the main reason we stuck with v1 for so long, and it's required for certain parts of our build and release process to function correctly.
bk2204
force-pushed
the
actions-checkout-v2
branch
from
43d3792
to
dea8b4e
Compare
bk2204
added a commit
to bk2204/git-lfs
that referenced
this pull request
Feb 15, 2022
actions/checkout@v2 "helpfully" overwrites the tag with the data from the ref, erasing the annotated tag, and therefore breaking git describe, which by default only checks annotated tags. Note that every tag except the one for the current head is preserved, so git describe uses an annotation that is based off the most recent tag. This behavior is described in actions/checkout#290. The original reporter claiming that a security fix had been applied has not provided details, and the behavior described should not be a vulnerability in a single-tenant Actions VM. Therefore, revert to actions/checkout@v1 to preserve functionality at the expense of a behavior which does not appear to describe an actual vulnerability. This reverts commit e3893b1, reversing changes made to eb0dc94.
bk2204
added a commit
that referenced
this pull request
Feb 15, 2022
Revert "Merge pull request #4795 from bk2204/actions-checkout-v2"
bk2204
added a commit
that referenced
this pull request
Feb 15, 2022
Revert "Merge pull request #4795 from bk2204/actions-checkout-v2"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actions/checkout workflow looks like it may have had a security-sensitive change to it in the latest v2. It doesn't look like it affects us, but let's update to be safe.
Switch to actions/checkout@v2 everywhere and use the fetch-depth: 0 argument, which makes us fetch the entire history. This is the main reason we stuck with v1 for so long, and it's required for certain parts of our build and release process to function correctly.
Fixes #4789