Makefile: remove legacy trimpath code #4938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisd8088
approved these changes
Apr 12, 2022
Before Go 1.13, it was possible to trim paths with GC flags and ASM flags. In Go 1.13, it became possible to simply specify -trimpath, at which point all the old behaviour became unnecessary. Since we require Go 1.13 in our code due to the use of the errors package, let's simplify our code by always using the -trimpath flag and omitting the old forms. The old forms additionally were broken when using a path with a space, which could happen on Windows if the current user's username contained a space (which is not uncommon).
|
I've made all of those changes and will merge when this looks green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before Go 1.13, it was possible to trim paths with GC flags and ASM flags. In Go 1.13, it became possible to simply specify -trimpath, at which point all the old behaviour became unnecessary.
Since we require Go 1.13 in our code due to the use of the errors package, let's simplify our code by always using the -trimpath flag and omitting the old forms. The old forms additionally were broken when using a path with a space, which could happen on Windows if the current user's username contained a space (which is not uncommon).