Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim space characters in the clone bar #952

Closed
richardtop opened this issue Oct 18, 2023 · 0 comments · Fixed by #965
Closed

Trim space characters in the clone bar #952

richardtop opened this issue Oct 18, 2023 · 0 comments · Fixed by #965
Labels
good first issue A change that shouldn't involve too much insider knowledge

Comments

@richardtop
Copy link

When copying a url from somewhere else it's often possible to accidentally copy some space characters in front or after the actual URL.

For example, instead of git@github.com:git-up/GitUp.git this will be copied: git@github.com:git-up/GitUp.git

As the result, GitUp shows this alert:
Screenshot 2023-10-18 at 19 27 23
Would be great to simply ignore these white space characters and continue to clone the actual URL.
@lucasderraugh lucasderraugh added the good first issue A change that shouldn't involve too much insider knowledge label Oct 18, 2023
prostolyubo added a commit to prostolyubo/GitUp that referenced this issue Jan 30, 2024
@prostolyubo
Trimming whitespaces from url while cloning (git-up#952)
c4fb1fb 
Added in CloneWindowController.m a trimming operation before passing contents of a text field into GitUpKit
@prostolyubo prostolyubo mentioned this issue Jan 30, 2024
Merged
lucasderraugh pushed a commit that referenced this issue Jan 30, 2024
@prostolyubo
Trimming whitespaces from url while cloning (#952) (#965)
477ce37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A change that shouldn't involve too much insider knowledge
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Trimming whitespaces from url while cloning (Fixes #952) prostolyubo/GitUp
2 participants
@lucasderraugh @richardtop