-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support: select two commits for diff #781
Conversation
Thank you for a PR! Do you have a screenshot to see how it would look like? |
Yes, please leave a description of the feature and a picture/gif/video of what has changed. Ultimately understanding what this contribution is without looking at the code is ideal. |
@lucasderraugh Could you have a look at this? Should be an awesome feature! |
I will test it out this week. Need to move 1.3.1 to stable release. |
I apologize for the long delay. Thank you @chargenius for implementing! I'll try to wrap this and a fix for the segmented control width into a release soon. |
Sorry for being a little late bringing this up: the help text is not completely correct after this change. |
@stigkj What do you mean by that? |
The help text shown on top of the window the first time you use a feature says that you can diff a selected commit against HEAD. I.e. it should be changed to say that it is possible to select 2 commits and diff them too. Or maybe have another help text when 2 commits are selected? |
No description provided.