-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application icon #945
Application icon #945
Conversation
Awesome icons! I'll chat with Pierre about getting access to the GitUp website so I can change the contents there. Would want to be able to do that before committing to a new icon just yet. As for the icon I think it's much more representative of "GitUp". I might play around with different colors (perhaps a blue instead of red) but other than that I think it looks wonderful. Thanks for putting in the effort. |
🙏 Funny you mention the different colours... I made a few variants: Thought about adding a setting in the Preferences window to be able to change the dock icon to suit your liking (a la Panic's Nova) but figured one step at a time... There's a blue variation in that list above but I'd personally shy away from going that route since it seems like ~90% of the icons out there (not exactly a methodical survey) rely on blue. I can send over SVGs if you prefer? |
This icon looks fantastic! One of those designs that is so simple and obvious in hindsight. Well done! As someone who's been bit by this countless times with app icons, the source SVGs should 100% be in source control! Also in terms of variants (when it gets to the preferences option for them), some less saturated options would be good to have as well, if just to appease folks (like me) who are so used to gitup being a white icon. |
I added the icon (in pink) in SVG format to the branch, not sure how to handle the different variations (or which variations I should include)? |
@davidfmiller I got access to change the website (should have asked a long time ago). I'm not completely sure how to allow for variations but I'll do a bit of investigation on it. If I can't pick one I'll try to find a color that works well as a default for us. I share the blue icon sentiment so I'll try something else. Maybe a red variant that matches our red color of the first branch shown in GitUp. |
Excellent! Let me know if you need a hand with anything, I do the webs as well. |
I think I'm going to just take the icon as is. I like the base color here and maybe I'll add the ability to choose later on, but for now I think this is a nice improvement. |
Just updated to GitUp 1.4.x from 1.3.5. This icon is far too bright and draws way too much attention to itself in the dock. The app icon‘s shadow doesn’t match other icons in the dock either. |
I'm open to proposed changes. We can also give the option to show other icons, but ultimately I think it's still better than the original in describing what the app does. |
The color red is often associated with error statuses or notifications. In macOS, icon badge labels also use a red color. This may be why @mdznr mentioned that it stands out too much on the dock and is distracting. Using a widely recognized accent color for different purposes can be confusing. |
I always love when I finally send things to the stable channel 😅. @mattgallagher I think this seems to be the sentiment in general is that the color itself is perhaps just too bright. I think I'll do almost what you did here which is to tone down the red a bit and make it a bit closer to the red branch line in the app. |
Love that this app is still maintained. Thanks for all the hard work you put into it. I can see why this seems like a relative big change... Maybe an option could be to add a setting for the icon so one can revert to the old one? |
I liked the previous one more :( |
As a counterpoint, I'd like to note that I really like the new icon, including its strong color. The previous one really did lack definition, to me. |
I'm not at all complaining about the change btw, always appreciate anyone who takes the time to contribute to FOSS ❤️❤️❤️ |
@lucasderraugh website still needs to be updated with a new icon |
Come on, Apple Music isn't THAT bad! (Slightly more seriously, I think red is just fine, but the option to switch between icon variants discussed earlier in the comment thread seems like it's probably a good idea. Maybe include the original icon for people who |
FWIW if a hand is required in updating / maintaining the GitUp website I'd be happy to assist… I would be sure to make it very bland and milquetoast in hopes of not ruffling people’s feathers 😊 |
@davidfmiller If you have time to tweak the icon to be a red closer to Music or less neon that would be helpful for me (maybe a similar gradient?). The website can use any design help as it hasn't changed since inception. I wouldn't worry about making people mad on the website (or in general). I'll have some time this weekend on a plane to work on switching icons for those that want the nostalgia. However, I think the new iconography is here to stay (few tweaks perhaps) as the default for a long time. I think it's a much clearer representation of GitUp than a white box with circles. |
@lucasderraugh will do! I’ll double-check the drop shadow used on the round rect, too… though I’m 99% sure I used the template that Apple provides for app icons. I’ll also provide a circley version that will work well for social media avatars to avoid weird default background colours surrounding the glyph, ex: Should GitUp’s site be saved in the project repo (ie: GitHub Pages)? 🫠 |
Are you ok? I did not mean to stir up strong feelings about this, I was just expressing my opinion. Not sure how a music player has anything to do with a git GUI by the way. I mean its fine if they want to be more flashy. I like having the option to change the app icon in the app itself, but note that macos already gives that option to users, I think you can drag an image file to the information details window in Finder for any app. |
After a year with the white GitUp icon, I really want to continue using it. However, now I am using a workaround from this issue with every GitHub update, which is, of course, inconvenient. Therefore, I would like to be able to select the icon directly from the app. |
Try this
You can actually keep a drawer full of these and change them throughout the day. I have one for gitup at coffee time, while I'm traveling, when I'm on vacation etc. This can actually work cross device as well and continues to function while the computer is turned off so you can still admire that crisp original logo during a power outage. |
More seriously, you might enjoy Pictogram as a more convenient workaround. It lets you change the icon of any app, and automatically reapplies the icon after app updates. |
A proposed fix for issues #216